Add `add note' to list of urls

Add `add note' to list of urls

[Andrew Cagney]

Hello,

I've added this to the src gnatsweb.pl interface.  It's my `I give up'
workaround to the xxx-prs@ mailto problem (you can't mailto it).

Does GCC want this?

Andrew

PS: GNATS 4 beta 2 is released

--------------070605060906030405020502
Content-Type: text/html;
  name="diffs"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
  filename="diffs"

2003-02-01  Andrew Cagney  <ac131313@redhat.com>

	* gnatsweb.pl (get_mailto_link): New function.
	(view): Print ``add note'' link.

Index: gnatsweb.pl
===================================================================
RCS file: /cvs/sourceware/cgi-bin/gnatsweb.pl,v
retrieving revision 1.40
diff -u -r1.40 gnatsweb.pl
--- gnatsweb.pl	2 Feb 2003 03:45:49 -0000	1.40
+++ gnatsweb.pl	2 Feb 2003 04:21:58 -0000
@@ -859,6 +859,24 @@
          . "send email to interested parties</a>\n";
  }

+# Return a link which sends email to PRMS
+sub get_addnote_link
+{
+  my($pr,%fields) = @_;
+
+  # NOTE: cagney/2003-01-31: Don't escape the interested parties
+  # e-mail list.  MOZILLA has a nasty bug were it doesn't re-adjust
+  # the e-mail list length after de-escaping it.  This causes MOZILLA
+  # to use "?Sub..." in the list of e-mail addresses.
+
+  my $mailto  = $config{'GNATS_ADDR'};
+
+  my $subject = $q->escape("Re: $fields{'Category'}/$pr: 
$fields{'Synopsis'}");
+
+  return "<a href=\"mailto:$mailto?Subject=$subject\">"
+        . "add note</a>\n";
+}
+
  # Look for text that looks like URLs and turn it into actual links.
  sub mark_urls
  {
@@ -903,8 +921,9 @@
    print $q->submit('cmd', 'edit')             if (can_edit());
    print " or "                                if (can_edit() && 
!$viewaudit);
    print $q->submit('cmd', 'view audit-trail') if (!$viewaudit);
-  print " or ",
-        get_mailto_link($pr, %fields), "</p>";
+  print " or ", get_addnote_link($pr, %fields);
+  print " or ", get_mailto_link($pr, %fields);
+  print "</p>";
    print $q->hr(),
          "<table>\n";
    print "<tr>\n<td><b>Reporter's email:</b></td>\n<td>",

--------------070605060906030405020502--

Re: Add `add note' to list of urls

[Gerald Pfeifer]

On Sun, 2 Feb 2003, Andrew Cagney wrote:
> I've added this to the src gnatsweb.pl interface.  It's my `I give up'
> workaround to the xxx-prs@ mailto problem (you can't mailto it).

We'll be switching to bugzilla RSN, but the change looks nice -- would
you mind sending it to  bug-gnats@gnu.org  so that it can be considered
for upstream sources as well?

Thanks,
Gerald
-- 
Gerald Pfeifer (Jerry)   gerald@pfeifer.com   http://www.pfeifer.com/gerald/