public inbox for
 help / color / mirror / Atom feed
From: Joel Brobecker <>
To: Joseph Myers <>
Cc: Joel Brobecker via Overseers <>,
	Joel Brobecker <>,
	Carlos O'Donell <>,
	Corinna Vinschen <>
Subject: Re: transition git-hooks on to Python 3.x
Date: Tue, 14 Dec 2021 07:39:37 +0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> > For this, what I'd like to propose is that we use a set of wrapper
> > scripts which provide the same hooks as the git-hooks, and which
> > only do the following: add the correct Python to the PATH, and
> > then call the real hook script in git-hooks.
> Adding to PATH, or other such variables, seems like it would also affect 
> external programs in hooks-bin run via configuration settings in the hooks 
> configuration (where those use "#! /usr/bin/env python3" or "#! 
> /usr/bin/env python", for example).  Have you concluded that this will 
> work OK for the existing hooks-bin code for the various repositories 
> (including the use of packages in 
> /home/gccadmin/.local/lib/python3.6/site-packages from GCC's 
> commit_checker script)?

I haven't no. I can do some testing if you tell me what testing
needs to be done. For now, I haven't been able to see the scripts
because they are in a location I do not have permissions to read.
Or, alternatively, we can agree on the location of the git-wrappers,
I can prepare a first version of the venv, and let you know when
it's ready, so you can do some testing, and then migrate to that
when you have done sufficient testing.

For the .local/lib/python3.6/site-packages, I propose we include
them into the venv that we create for the wrapper. The
gives a list of all the Python packages we want to have, so I can
add those used by GCC.


  reply	other threads:[~2021-12-14  3:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-12 11:32 Joel Brobecker
2021-12-13  9:23 ` Mark Wielaard
2021-12-15  9:30   ` Ivo Raisr
2021-12-16  2:16     ` Joel Brobecker
2021-12-13 11:35 ` Corinna Vinschen
2021-12-13 11:47   ` Joel Brobecker
2021-12-13 22:20 ` Joseph Myers
2021-12-14  3:39   ` Joel Brobecker [this message]
2021-12-17  2:46 ` Joel Brobecker
2021-12-19  4:45   ` Joel Brobecker
2021-12-20  5:10     ` Joel Brobecker
2022-01-16 10:06     ` Joel Brobecker
2022-01-17 10:02       ` Corinna Vinschen
2022-01-20  5:27         ` Joel Brobecker
2022-01-20 10:04           ` Corinna Vinschen
2022-01-20 13:54             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).