From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 3BA2D3858C60 for ; Tue, 14 Dec 2021 03:39:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3BA2D3858C60 Received: by mail-wr1-x42a.google.com with SMTP id t18so30171012wrg.11 for ; Mon, 13 Dec 2021 19:39:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f8jcCmJT+j/34nZrt908kK+tYDEURycz4KMMqlfAm7A=; b=feUAsHplGF0IOe/khnMYFlXmYACyT8l4IYsloqNGni3+j27Ilg+FiElmU72xKgMsDJ UEvcMHUO3xf5yqUIFbBvf/tE63+2N0BS+er0tPpp5A/bK3/AylKzPIo23yM+GaBqz28u CF45MoNEoqNe2udI6DbEtr+wJPprR8u3oto7PmA4ElUi6cY1BxbH8B70s5kPhq8WSTM4 eBbFjou0MU6cxqWGfFInHeFyVRWXu5lJK8xFj2bt7IZi8JdoKr3L9Fy5AjG6MQFo7yQb oF/Of1yBY00lYHI/PSFzomJDysugal33/t9dxlFLX2eIoK7YahhshP+J+ZLLxlj+/miM /rMw== X-Gm-Message-State: AOAM532vI7JbAqsoVbII7/GtpSDudcGqqaiDNXj51Y4Z7lMx3RA2TDdn 0VAukJITnNQecI2xmGCGXarxsEg6NcMI X-Google-Smtp-Source: ABdhPJyJ/4DbvuBb8aEaVblPEUbrH82Ckafc+ABW1BYGnF7mfexkEe9YGgrqCYLlTt86pJH+QgWrFQ== X-Received: by 2002:a05:6000:23a:: with SMTP id l26mr2832059wrz.215.1639453180315; Mon, 13 Dec 2021 19:39:40 -0800 (PST) Received: from takamaka.home (lfbn-reu-1-483-157.w92-130.abo.wanadoo.fr. [92.130.72.157]) by smtp.gmail.com with ESMTPSA id k7sm9759745wri.110.2021.12.13.19.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 19:39:39 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id 41F93A49EE; Tue, 14 Dec 2021 07:39:37 +0400 (+04) Date: Tue, 14 Dec 2021 07:39:37 +0400 From: Joel Brobecker To: Joseph Myers Cc: Joel Brobecker via Overseers , Joel Brobecker , Carlos O'Donell , Corinna Vinschen Subject: Re: transition git-hooks on sourceware.org to Python 3.x Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: overseers@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Overseers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2021 03:39:43 -0000 > > For this, what I'd like to propose is that we use a set of wrapper > > scripts which provide the same hooks as the git-hooks, and which > > only do the following: add the correct Python to the PATH, and > > then call the real hook script in git-hooks. > > Adding to PATH, or other such variables, seems like it would also affect > external programs in hooks-bin run via configuration settings in the hooks > configuration (where those use "#! /usr/bin/env python3" or "#! > /usr/bin/env python", for example). Have you concluded that this will > work OK for the existing hooks-bin code for the various repositories > (including the use of packages in > /home/gccadmin/.local/lib/python3.6/site-packages from GCC's > commit_checker script)? I haven't no. I can do some testing if you tell me what testing needs to be done. For now, I haven't been able to see the scripts because they are in a location I do not have permissions to read. Or, alternatively, we can agree on the location of the git-wrappers, I can prepare a first version of the venv, and let you know when it's ready, so you can do some testing, and then migrate to that when you have done sufficient testing. For the .local/lib/python3.6/site-packages, I propose we include them into the venv that we create for the wrapper. The README.md gives a list of all the Python packages we want to have, so I can add those used by GCC. -- Joel