From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id A8B333858D35 for ; Sun, 16 Jan 2022 10:06:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A8B333858D35 Received: by mail-wm1-x335.google.com with SMTP id p1-20020a1c7401000000b00345c2d068bdso16924494wmc.3 for ; Sun, 16 Jan 2022 02:06:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bJp07oY6oEozqyMOnR5Ko8FYsSQU3pHbI54GQhf3W9c=; b=1/GCaK+QzCl3/W6rjueq94b3vx2ODRZHGuNNNm2gJCPjyB8HTnPglf07jL9pK5RAdr I6TGOalBz9EXVlCc7kGZM9WxB/kkol2LRkcJb/oMLxdkUKhElsaVX5I3obILFFSXsfOP XNUYZfqg/iFt0fQ4AQlIlv1v8A9AAZCOHE/FrVdV5JTKMcddStw+RSefF2CducIL6LYQ qc+GlORPdLe9mF0TLq3xGcbHsytIE8Gn5fLAvhhjKsamMwLYV+/Jz+2E4snIcuCrRr0u ECDn/F000oN6onVX609NY9WkRzWLRxacoPzx5SoRJKx3M5X7XpMvHR4JOlJsvMQ8K9/z iOHg== X-Gm-Message-State: AOAM532abmmJicVNCZ7yn35G5oky+LryzEfn+94iJzutS/31++XctqBr MhvKCzSdZ5RBy1tFJ7fBP1VA4sM/SOfY X-Google-Smtp-Source: ABdhPJzqTeBU1gK1yRySVMErPM13jQu2hfI9UzIaRDjkw8dNIzKmCf1alDBC9UxNDRRN23jdyJmbKA== X-Received: by 2002:a5d:5229:: with SMTP id i9mr15466429wra.68.1642327591719; Sun, 16 Jan 2022 02:06:31 -0800 (PST) Received: from takamaka.home ([2a01:cb22:1d5:1100:81b7:77bd:9588:f82b]) by smtp.gmail.com with ESMTPSA id q3sm10369692wrr.55.2022.01.16.02.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Jan 2022 02:06:31 -0800 (PST) Received: by takamaka.home (Postfix, from userid 1000) id 63AAAA84C2; Sun, 16 Jan 2022 14:06:28 +0400 (+04) Date: Sun, 16 Jan 2022 14:06:28 +0400 From: Joel Brobecker To: overseers@sourceware.org Cc: Joel Brobecker , Joseph Myers , Carlos O'Donell , Corinna Vinschen , Ivo Raisr Subject: Re: transition git-hooks on sourceware.org to Python 3.x Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: overseers@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Overseers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jan 2022 10:06:34 -0000 Hi everyone, Happy New Year! For binutils-gdb, the transition has been made a few weeks ago, and so far so good :). So I'm inviting you all to transition this new version at your convenience. Remember that, if your project's configuration calls some Python hooks, you'll probably want to double-check that they are compatible with Python 3.x! Cheers :) On Sun, Dec 19, 2021 at 08:45:39AM +0400, Joel Brobecker wrote: > Quick update: > > I have set up the hooks wrappers at the following location: > > /home/gdbadmin/shared-scripts/git-hooks-wrapper > > For the record, here is the list of commands I used to create it: > > # Clone the git-hooks-wrapper scrips > > $ mkdir shared-scripts > $ cd shared-scripts/ > $ git clone $HOME/GDBADMIN-BARE-REPOS/git-hooks-wrapper/ > $ cd git-hooks-wrapper/ > > # Add a Python 3.9 install, and then the venv for the wrappers: > > $ tar xf ~/brobecke/py3-git-hooks/python3.9-3.9.7-x86_64-linux-bin.tar.gz > $ mv python3.9-3.9.7-x86_64-linux-bin/ python-3.9.7 > $ export PATH=`pwd`/python-3.9.7/bin:$PATH > $ python3 -m venv python3-for-git-hooks > $ . ./python3-for-git-hooks/bin/activate > $ python3 -m pip install pip --upgrade > $ python3 -m pip install black e3-core flake8 pre-commit \ > pytest pytest-cov pytest-xdist > > # Clone the git-hooks, and run the validation test to make sure > # the Python venv has everything the git-hooks need (note that > # this doesn't include the wrappers in the testing, unfortunately). > # > # I might look at enhancing the testsuite to include the use of > # those wrappers instead of the hooks themselves, at some point, > # but it's a bit of work, so only if we find the regular need to > # test the wrappers. > > $ git clone https://github.com/adacore/git-hooks > $ cd git-hooks/testsuite/ > $ ./run-validation-tests > > My plan is to transition the binutils-gdb repository to it on Monday > morning (European timezone). To do so, what I will do is: > > $ /git/binutils-gdb.git > $ mv hooks{,.legacy-python2} \ > && ln -s /home/gdbadmin/shared-scripts/git-hooks-wrapper/hooks hooks > > I'll monitor the hooks behavior throughout the end of the year, > and if all goes well, I suggest other projects who are ready > (after reviewing their python scripts used by their project's config) > do the same. I can provide assistance towards the transition, > if you'd like. > > -- > Joel -- Joel