From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
 by sourceware.org (Postfix) with ESMTPS id D2A7538376C4
 for <overseers@sourceware.org>; Wed, 25 May 2022 21:48:53 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2A7538376C4
Received: from reform (deer0x07.wildebeest.org [172.31.17.137])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 7AD88302BBEB;
 Wed, 25 May 2022 23:48:52 +0200 (CEST)
Received: by reform (Postfix, from userid 1000)
 id D5A762E83D83; Wed, 25 May 2022 23:48:51 +0200 (CEST)
Date: Wed, 25 May 2022 23:48:51 +0200
From: Mark Wielaard <mark@klomp.org>
To: Martin =?utf-8?B?TGnFoWth?= <mliska@suse.cz>
Cc: overseers@sourceware.org
Subject: Re: [PATCH] Add openSUSE builders.
Message-ID: <Yo6kQ8JOSyCKvcJJ@wildebeest.org>
References: <82f57f9255f51dbeb3d7ff425f49a02c23804943.camel@klomp.org>
 <1a016b65-ba54-5b5e-3024-ec0531db2f52@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1a016b65-ba54-5b5e-3024-ec0531db2f52@suse.cz>
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: overseers@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Overseers mailing list <overseers.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/overseers>,
 <mailto:overseers-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/overseers/>
List-Post: <mailto:overseers@sourceware.org>
List-Help: <mailto:overseers-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/overseers>,
 <mailto:overseers-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2022 21:48:55 -0000

Hi Martin,

On Wed, May 25, 2022 at 10:01:30PM +0200, Martin Liška wrote:
> Add builders for bzip2 and elfutils.
> 
> Let's start with these for testing purpose. I'm going to add others soon..

Note you mispelled the container names in the elfutils builders (but
they are correct in the bzip2 builders).

> +elfutils_opensusetw_x86_64_builder = util.BuilderConfig(
> +        name="elfutils-opensusetw-x86_64",
> +	properties={'container-file':
> +		    readContainerFile('opensusetw-latest')},

opensuse-tumbleweed

> +	workernames=vm_workers,
> +        tags=["elfutils", "opensusetw", "x86_64"],
> +        factory=elfutils_factory_distcheck)
> +c['builders'].append(elfutils_opensusetw_x86_64_builder)
> +
> +elfutils_opensuseleap_x86_64_builder = util.BuilderConfig(
> +        name="elfutils-opensuseleap-x86_64",
> +	properties={'container-file':
> +		    readContainerFile('opensuseleap-latest')},

opensuse-leap

> +	workernames=vm_workers,
> +        tags=["elfutils", "opensuseleap", "x86_64"],
> +        factory=elfutils_factory_distcheck)
> +c['builders'].append(elfutils_opensuseleap_x86_64_builder)

Everything else looks correct. Note that I only noticed because I ran
buildbot checkconfig builder locally.

I added you to the builder group so you can push yourself after the
fix (and please do run checkconfig locally). And so you can help if
anything blows up :)

Cheers,

Mark