From: Mark Wielaard <mark@klomp.org>
To: Overseers mailing list <overseers@sourceware.org>
Cc: Yann Droneaud <ydroneaud@opteya.com>
Subject: Re: Fwd: https patchwork URLs (was "Re: Patchwork account confirmation")
Date: Sat, 11 Jun 2022 15:15:33 +0200 [thread overview]
Message-ID: <YqSVdYGXSzgJIbhq@wildebeest.org> (raw)
In-Reply-To: <b9f13cae-88b3-442a-abc3-bfec482953b0@opteya.com>
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
Hi Yann,
Thanks for noticing patchwork still uses http instead of https in some
places.
On Tue, Jun 07, 2022 at 03:38:32PM +0200, Yann Droneaud via Overseers wrote:
> It would be great if TLS/SSL would always be prefered:
>
> 1) http://patchwork.sourceware.org/ redirect to
> https://patchwork.sourceware.org/
It should now always redirect to https for any
> 2) email uses https://patchwork.sourceware.org/
All mail templates were updated to use https.
Please do report if you find any more plain http instead of https
links.
Thanks,
Mark
[-- Attachment #2: https-template-mails.patch --]
[-- Type: text/x-diff, Size: 3758 bytes --]
commit d3debb1568df0ce6728e62b1b1f380a8023c0d94
Author: Mark Wielaard <mark@klomp.org>
Date: Sat Jun 11 13:02:46 2022 +0000
Replace http:// with https:// in templates/patchwork/mails
diff --git a/patchwork/templates/patchwork/mails/activation.txt b/patchwork/templates/patchwork/mails/activation.txt
index 34e2fce..16cc30c 100644
--- a/patchwork/templates/patchwork/mails/activation.txt
+++ b/patchwork/templates/patchwork/mails/activation.txt
@@ -3,7 +3,7 @@ Hi,
This email is to confirm your account on the patchwork patch-tracking
system. You can activate your account by visiting the url:
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
If you didn't request a user account on patchwork, then you can ignore
this mail.
diff --git a/patchwork/templates/patchwork/mails/optin-request.txt b/patchwork/templates/patchwork/mails/optin-request.txt
index bd40e67..fe8fd51 100644
--- a/patchwork/templates/patchwork/mails/optin-request.txt
+++ b/patchwork/templates/patchwork/mails/optin-request.txt
@@ -5,7 +5,7 @@ email from the Patchwork system at {{site.domain}}.
To complete the opt-in process, visit:
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
If you didn't request this opt-in, you don't need to do anything.
diff --git a/patchwork/templates/patchwork/mails/optout-request.txt b/patchwork/templates/patchwork/mails/optout-request.txt
index b1732fd..a740590 100644
--- a/patchwork/templates/patchwork/mails/optout-request.txt
+++ b/patchwork/templates/patchwork/mails/optout-request.txt
@@ -5,7 +5,7 @@ from the Patchwork system at {{site.domain}}.
To complete the opt-out process, visit:
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
If you didn't request this opt-out, you don't need to do anything.
diff --git a/patchwork/templates/patchwork/mails/patch-change-notification.txt b/patchwork/templates/patchwork/mails/patch-change-notification.txt
index 7d04cff..0396a86 100644
--- a/patchwork/templates/patchwork/mails/patch-change-notification.txt
+++ b/patchwork/templates/patchwork/mails/patch-change-notification.txt
@@ -3,7 +3,7 @@ Hello,
The following patch{{notifications|length|pluralize:"es"}} (submitted by you) {{notifications|length|pluralize:"has,have"}} been updated in Patchwork:
{% for notification in notifications %}
* {{notification.patch.project.linkname}}: {{notification.patch.name|safe}}
- - http://{{site.domain}}{{notification.patch.get_absolute_url}}
+ - https://{{site.domain}}{{notification.patch.get_absolute_url}}
- for: {{notification.patch.project.name}}
was: {{notification.orig_state}}
now: {{notification.patch.state}}
@@ -17,4 +17,4 @@ Happy patchworking.
This is an automated mail sent by the Patchwork system at
{{site.domain}}. To stop receiving these notifications, edit
your mail settings at:
- http://{{site.domain}}{% url 'mail-settings' %}
+ https://{{site.domain}}{% url 'mail-settings' %}
diff --git a/patchwork/templates/patchwork/mails/user-link.txt b/patchwork/templates/patchwork/mails/user-link.txt
index d0a3c97..e9f5019 100644
--- a/patchwork/templates/patchwork/mails/user-link.txt
+++ b/patchwork/templates/patchwork/mails/user-link.txt
@@ -7,6 +7,6 @@ This email is to confirm that you own the email address:
So that you can add it to your Patchwork profile. You can confirm this
email address by visiting the url:
- http://{{site.domain}}{% url 'confirm' key=confirmation.key %}
+ https://{{site.domain}}{% url 'confirm' key=confirmation.key %}
Happy patchworking.
next prev parent reply other threads:[~2022-06-11 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cee35da4-73d3-5903-b3e6-53a584d6fe3a@opteya.com>
2022-06-07 13:38 ` Yann Droneaud
2022-06-11 13:15 ` Mark Wielaard [this message]
2022-06-11 15:55 ` Yann Droneaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqSVdYGXSzgJIbhq@wildebeest.org \
--to=mark@klomp.org \
--cc=overseers@sourceware.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).