From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id A49E33858D39 for ; Mon, 13 Dec 2021 22:20:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A49E33858D39 IronPort-SDR: Bu4lD+mc3huHL0pTnkOESQVhw1kwdqzHRjiO3ZcPtDhOO/mKxqdM33s2kR5n0WIsDK61ciJwmr U6NkI8G3cZ/xq9lE58ehvQnFrUP5eNpb5B9FAQ8H/mNm/9Cs1S/d1Nw9F29Dgyun2Aow9WO0/6 xLNAVYTCv0IugrvdXiV0MHxlpzrWjktc89PNbBg5UyxZwYS+nXc7X+Tx66I51qsSHrTZxX4uBE T3rhXFwJkjTC3JZdV3qh3xNYLpXiTbz1svlleBMWUSS5d5+p3frGCl+P1Hg4uOulyNPYZVU83w 2TN9Bvee5fwQU/J3KIknHLVb X-IronPort-AV: E=Sophos;i="5.88,203,1635235200"; d="scan'208";a="72160844" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 13 Dec 2021 14:20:15 -0800 IronPort-SDR: SdKJ1dT6l7gg3mzWP5iuNPLMpUghQjDTJQapeaDbl+4vx1jk7Q4HhXd5vc4E0deS7MDl4yx7MH t1yX4PqdFYeX1qIWWIEGit4ICNOcdW6NK865ni4++iIJplnxK+hZBfY0hPQSIgcTBtRnLX0yEM 3SafwqXu39PQLwfEq2Q74SHl+NHidw8olf6KNzmIYrkZ5Q5VWpYGNIr009HIUO8c+yLMB/YXf2 P9DPu8ElWNUMOFM7NfX7jkDp7hvFQQy4v6845uo6yrU92CIsS2malmb+mU0fvC2FWRv5II/yI8 wg0= Date: Mon, 13 Dec 2021 22:20:09 +0000 From: Joseph Myers X-X-Sender: jsm28@digraph.polyomino.org.uk To: Joel Brobecker via Overseers CC: Joel Brobecker , Carlos O'Donell , Corinna Vinschen Subject: Re: transition git-hooks on sourceware.org to Python 3.x In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-3116.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: overseers@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Overseers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 22:20:18 -0000 On Sun, 12 Dec 2021, Joel Brobecker via Overseers wrote: > For this, what I'd like to propose is that we use a set of wrapper > scripts which provide the same hooks as the git-hooks, and which > only do the following: add the correct Python to the PATH, and > then call the real hook script in git-hooks. Adding to PATH, or other such variables, seems like it would also affect external programs in hooks-bin run via configuration settings in the hooks configuration (where those use "#! /usr/bin/env python3" or "#! /usr/bin/env python", for example). Have you concluded that this will work OK for the existing hooks-bin code for the various repositories (including the use of packages in /home/gccadmin/.local/lib/python3.6/site-packages from GCC's commit_checker script)? -- Joseph S. Myers joseph@codesourcery.com