From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id EC89F3858D38; Tue, 24 Jan 2023 15:02:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC89F3858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674572579; bh=B5BlLWHH7WghkmVc/s2JpJ6DRjCkxSEa8bpge3AUJLs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Im9Vs2QC4mzZd5fVvsnfTKaMlayCTG9BhvBVQguYVo22KfG5Yf8L3fKFBp++uuDNx 3nMiVLEVGjhnFuS9iXboJPx0B4PvjS9Mkj8qwnjzRaWgLXfmfmVG5AR+Aly5PhotRk i7cW5UJnMpvkpwUpQQgRD1rKPvn8SnNrrLTV3LZQ= From: "carlos at redhat dot com" To: overseers@sourceware.org Subject: [Bug Infrastructure/30042] patchworks should automatically notice a pushed patch Date: Tue, 24 Jan 2023 15:02:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: sourceware X-Bugzilla-Component: Infrastructure X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: carlos at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: overseers at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30042 Carlos O'Donell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carlos at redhat dot com --- Comment #1 from Carlos O'Donell --- (In reply to Tom Tromey from comment #0) > Consider this patch: >=20 > https://patchwork.sourceware.org/project/gdb/patch/20230122212801.1926063= -1- > tom@tromey.com/ >=20 > I used git send-email to send this patch and patchworks dutifully > logged it. Then I pushed the patch -- but patchworks did nothing, > I had to go into the web interface to explicitly mark it as committed. >=20 > I think patchworks ought to notice this situation. This is easier said than done unfortunately. (1) Out of the box feature. This is not functionality that patchwork provides. I would be an RFE for patchwork upstream (https://github.com/getpatchwork/patchwork/). (2) Commit cleanup script. Alternatively, in glibc we run a script to compare commits against patchwork patches and close those that have been committed. The first problem we saw here was that it requires discipline from the community to commit *exactly* what was posted and agreed upon in order to m= ake the checking less error prone. In glibc we have adopted a stronger policy that you should only commit what= the author provided, or ask the author to change it. My own opinion is that it = is disrespectful to change what the author is submitting. The only allowed changes are additions of Reviewed-by, Tested-by tags in the commit message. In either (1) or (2) I think this is up to the projects to run the scripts = that they need. --=20 You are receiving this mail because: You are the assignee for the bug.=