Re: [PATCH] Add openSUSE builders.

["Martin Liška" <mliska@suse.cz>]

On 5/25/22 23:48, Mark Wielaard wrote:
> Hi Martin,
> 
> On Wed, May 25, 2022 at 10:01:30PM +0200, Martin Liška wrote:
>> Add builders for bzip2 and elfutils.
>>
>> Let's start with these for testing purpose. I'm going to add others soon..
> 
> Note you mispelled the container names in the elfutils builders (but
> they are correct in the bzip2 builders).

Sure, thanks for heads up.

> 
>> +elfutils_opensusetw_x86_64_builder = util.BuilderConfig(
>> +        name="elfutils-opensusetw-x86_64",
>> +	properties={'container-file':
>> +		    readContainerFile('opensusetw-latest')},
> 
> opensuse-tumbleweed
> 
>> +	workernames=vm_workers,
>> +        tags=["elfutils", "opensusetw", "x86_64"],
>> +        factory=elfutils_factory_distcheck)
>> +c['builders'].append(elfutils_opensusetw_x86_64_builder)
>> +
>> +elfutils_opensuseleap_x86_64_builder = util.BuilderConfig(
>> +        name="elfutils-opensuseleap-x86_64",
>> +	properties={'container-file':
>> +		    readContainerFile('opensuseleap-latest')},
> 
> opensuse-leap
> 
>> +	workernames=vm_workers,
>> +        tags=["elfutils", "opensuseleap", "x86_64"],
>> +        factory=elfutils_factory_distcheck)
>> +c['builders'].append(elfutils_opensuseleap_x86_64_builder)
> 
> Everything else looks correct. Note that I only noticed because I ran
> buildbot checkconfig builder locally.

Fixed and pushed.

> 
> I added you to the builder group so you can push yourself after the
> fix (and please do run checkconfig locally). And so you can help if
> anything blows up :)

Cool, thanks for the trust.

Cheers,
Martin

> 
> Cheers,
> 
> Mark