Re: [MIPS] Add saa and saad instructions for octeon

Re: [MIPS] Add saa and saad instructions for octeon

[David Daney]

On 11/10/2011 09:26 PM, Andrew Pinski wrote:
> Hi,
>    This patch adds the saa and saad instructions for Octeon.   They are
> not part of the original Octeon but are part of the Octeon+.  We at
> Cavium don't feel the need to add a new arch for it since this is the
> only difference instruction wise and the original Octeon is no longer
> in production.
>
> OK? Tested with a cross binutils to mips64-linux-gnu with no regressions.
>
> Thanks,
> Andrew Pinski
>
> PS I don't currently have binutils write access but Cavium has a
> blanket copyright assignment on file.
>

If approved, I can commit it, but really the overseers should turn on 
commit permissions for you.

David Daney


> gas/ChangeLog:
> * config/tc-mips.c (macro): Add support for M_SAA_AB and M_SAAD_AB.
> (mips_ip<case '('>): Allow 's' after '('.
>
> gas/testsuite/ChangeLog:
> * gas/mips/mips.exp: Add octeon-saa-saad.
> * gas/mips/octeon-saa-saad.d: New file.
> * gas/mips/octeon-saa-saad.s: New file
>
> include/opcode/ChangeLog:
> * mips.h (M_SAA_AB, M_SAAD_AB): New enum values.
>
> opcodes/ChangeLog:
> * mips-opc.c (micromips_opcodes): Add "saa" and "saad".

Re: [MIPS] Add saa and saad instructions for octeon

[David Daney]

On 11/24/2011 02:58 PM, Andrew Pinski wrote:
> On Thu, Nov 24, 2011 at 12:50 PM, Richard Sandiford
> <rdsandiford@googlemail.com>  wrote:
>> Andrew Pinski<andrew.pinski@caviumnetworks.com>  writes:
>>> bfd/ChangeLog:
>>> * archures.c (bfd_mach_mips_octeonp): New macro.
>>> * bfd-in2.h: Regenerate.
>>> * bfd/cpu-mips.c (I_mipsocteonp): New enum value.
>>> (arch_info_struct): Add bfd_mach_mips_octeonp.
>>> * elfxx-mips.c (mips_set_isa_flags): Add bfd_mach_mips_octeonp.
>>> (mips_mach_extensions): Add bfd_mach_mips_octeonp.
>>>
>>> gas/ChangeLog:
>>> * config/tc-mips.c (CPU_IS_OCTEON): New macro function.
>>> (CPU_HAS_SEQ): Change to use CPU_IS_OCTEON.
>>> (NO_ISA_COP): Likewise.
>>> (macro)<ld_st>: Add support when off0 is true.
>>> Add support for M_SAA_AB, M_SAA_OB, M_SAAD_OB and M_SAAD_AB.
>>> (mips_cpu_info_table): Add octeon+.
>>> * doc/c-mips.texi: Document octeon+ as an acceptable value for -march=
>>>
>>> gas/testsuite/ChangeLog
>>> * gas/mips/mips.exp: Add octeon+ for an architecture.
>>> Run octeon-saa-saad test.
>>> (run_dump_test_arch): For Octeon architectures, also try octeon@.
>>> * gas/mips/octeon-pref.d: Remove -march=octeon from command line.
>>> * gas/mips/octeon.d: Likewise.
>>> * gas/mips/octeon-saa-saad.d: New file.
>>> * gas/mips/octeon-saa-saad.s: New file
>>>
>>> include/opcode/ChangeLog:
>>> * mips.h (INSN_CHIP_MASK): Update according to INSN_OCTEONP.
>>> (INSN_OCTEONP): New macro.
>>> (CPU_OCTEONP): New macro.
>>> (OPCODE_IS_MEMBER): Add Octeon+.
>>> (M_SAA_AB, M_SAAD_AB, M_SAA_OB, M_SAAD_OB): New enum values.
>>>
>>> opcodes/ChangeLog:
>>> * mips-dis.c (mips_arch_choices): Add Octeon+.
>>> * mips-opc.c (IOCT): Include Octeon+.
>>> (IOCTP): New macro.
>>> (mips_builtin_opcodes): Add "saa" and "saad".
>>
>> OK, thanks.  Please run the binutils testsuite for a mips*-linux-gnu
[...]
>
> Can you apply the patch since I don't have write cvs access yet or can
> I receive write CVS access?
>

It would be best to grant Andrew write access I think, as there are more 
patches to come.

In the short term, I can commit the patch if that would make things easier.

David Daney

Re: [MIPS] Add saa and saad instructions for octeon

[Richard Sandiford]

David Daney <ddaney@caviumnetworks.com> writes:
> It would be best to grant Andrew write access I think, as there are more 
> patches to come.

+1 FWIW.  Nick?

Richard

Re: [MIPS] Add saa and saad instructions for octeon

[nick clifton]

Hi Richard, Hi Andrew,
>> It would be best to grant Andrew write access I think, as there are more
>> patches to come.
>
> +1 FWIW.  Nick?

Agreed - Andrew please fill out the form at:

   http://sourceware.org/cgi-bin/pdw/ps_form.cgi

Using my email address as approver.

Cheers
   Nick

Re: [MIPS] Add saa and saad instructions for octeon

[Christopher Faylor]

On Tue, Nov 29, 2011 at 04:47:02PM +0000, nick clifton wrote:
>Hi Richard, Hi Andrew,
>>> It would be best to grant Andrew write access I think, as there are more
>>> patches to come.
>>
>> +1 FWIW.  Nick?
>
>Agreed - Andrew please fill out the form at:
>
>   http://sourceware.org/cgi-bin/pdw/ps_form.cgi
>
>Using my email address as approver.

No, please don't.  Andrew already has an account.  That form is for
creation of a new account.

Just wait for someone to update the group ownership.

cgf