Re: viewcvs: Python error

Re: viewcvs: Python error

[Georg-Johann Lay]

As I don't know where to report and viewcvs still breaks, CCing overseers.

http://gcc.gnu.org/viewcvs/trunk/gcc/testsuite/gcc.dg/unroll_1.c?view=markup&pathrev=174762

> http://gcc.gnu.org/viewcvs/trunk/gcc/testsuite/gcc.dg/unroll_1.c?view=markup&pathrev=174762
> 
> Since several days now I observe Python exceptions in viewcvs like that:
> 
> An Exception Has Occurred
> Python Traceback
> 
> Traceback (most recent call last):
>   File "/usr/lib/python2.3/site-packages/viewvc/lib/viewvc.py", line 4318, in main
>     request.run_viewvc()
>   File "/usr/lib/python2.3/site-packages/viewvc/lib/viewvc.py", line 397, in run_viewvc
>     self.view_func(self)
>   File "/usr/lib/python2.3/site-packages/viewvc/lib/viewvc.py", line 1763, in view_markup
>     markup_or_annotate(request, 0)
>   File "/usr/lib/python2.3/site-packages/viewvc/lib/viewvc.py", line 1696, in markup_or_annotate
>     path[-1], mime_type)
>   File "/usr/lib/python2.3/site-packages/viewvc/lib/viewvc.py", line 1509, in markup_stream_pygments
>     from pygments.formatters import HtmlFormatter
>   File "/usr/lib/python2.3/site-packages/pygments/formatters/__init__.py", line 14, in ?
>     from pygments.formatters._mapping import FORMATTERS
>   File "/usr/lib/python2.3/site-packages/pygments/formatters/_mapping.py", line 20, in ?
>     from pygments.formatters.html import HtmlFormatter
>   File "/usr/lib/python2.3/site-packages/pygments/formatters/html.py", line 17, in ?
>     from pygments.token import Token, Text, STANDARD_TYPES
>   File "/usr/lib/python2.3/site-packages/pygments/token.py", line 47, in ?
>     Token       = _TokenType()
>   File "/usr/lib/python2.3/site-packages/pygments/token.py", line 26, in __init__
>     self.subtypes = set()
> NameError: global name 'set' is not defined

Vincent Legoll wrote:
>> File "/usr/lib/python2.3/site-packages/pygments/token.py", line 26, in __init__
>> self.subtypes = set()
>> NameError: global name 'set' is not defined
> 
> set() appeared in python2.4 according to:
> http://docs.python.org/release/2.3.5/lib/built-in-funcs.html
> vs
> http://docs.python.org/release/2.4/lib/built-in-funcs.html
> 
> So the fix may be to upgrade python on the host, and the cause may be that
> a new version of viewcvs has been installed which now use set() whereas the
> previous didn't...
> 

Re: viewcvs: Python error

[Vincent Legoll]

On Fri, Jun 24, 2011 at 12:01 PM, Georg-Johann Lay <avr@gjlay.de> wrote:
> As I don't know where to report and viewcvs still breaks, CCing overseers.

After a bit more investigation...

This may be the changeset that broke pygments running on older
pythons (< 2.4):

https://bitbucket.org/birkenfeld/pygments-main/changeset/8d3fbbf1ffdb

Now as what to do about it, I don't know... The host seems to have very old
software, maybe now is the time for an upgrade...

-- 
Vincent Legoll

Re: viewcvs: Python error

[Ian Lance Taylor]

Vincent Legoll <vincent.legoll@gmail.com> writes:

> This may be the changeset that broke pygments running on older
> pythons (< 2.4):
>
> https://bitbucket.org/birkenfeld/pygments-main/changeset/8d3fbbf1ffdb
>
> Now as what to do about it, I don't know... The host seems to have very old
> software, maybe now is the time for an upgrade...

Thanks for identifying the patch.  I applied the reverse patch manually
to gcc.gnu.org, and the problem appears to be fixed, at least for now.

Ian

Re: viewcvs: Python error

[Georg-Johann Lay]

Ian Lance Taylor schrieb:
> Vincent Legoll writes:
> 
>>This may be the changeset that broke pygments running on older
>>pythons (< 2.4):
>>
>>https://bitbucket.org/birkenfeld/pygments-main/changeset/8d3fbbf1ffdb
> 
> Thanks for identifying the patch.  I applied the reverse patch manually
> to gcc.gnu.org, and the problem appears to be fixed, at least for now.
> 
> Ian

Hi, thanks for the fix, but it appears the revert changed bit too much. 
This issue has returned:

http://gcc.gnu.org/ml/gcc/2011-04/msg00336.html

Johann

Re: viewcvs: Python error

[Ian Lance Taylor]

> Ian Lance Taylor schrieb:
>
>> Thanks for identifying the patch.  I applied the reverse patch manually
>> to gcc.gnu.org, and the problem appears to be fixed, at least for now.
>>
>> Ian
>
> Hi, thanks for the fix, but it appears the revert changed bit too
> much. This issue has returned:
>
> http://gcc.gnu.org/ml/gcc/2011-04/msg00336.html

Thanks.  Fixed again.

(That happened when I updated the viewvc package, it wasn't due to the
change I made.)

Ian