public inbox for prelink@sourceware.org
 help / color / mirror / Atom feed
From: Maxim Kuvyrkov <maxim@codesourcery.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: <prelink@sourceware.org>
Subject: Re: [PATCH, cross prelink] 0001-Pull-ld.so-s-name-from-PT_INTERP-to-avoid-the-runtim.patch
Date: Sat, 26 May 2012 03:42:00 -0000	[thread overview]
Message-ID: <10862750-7E5E-4B2C-9FEF-1EADEB197044@codesourcery.com> (raw)
In-Reply-To: <4F8496BA.3010706@windriver.com>

On 11/04/2012, at 8:23 AM, Mark Hatle wrote:

> On 4/10/12 2:56 PM, Maxim Kuvyrkov wrote:
>> On 11/04/2012, at 7:46 AM, Mark Hatle wrote:
>> 
>>> On 4/10/12 2:27 PM, Maxim Kuvyrkov wrote:
>>>> Mark,
>>>> 
>>>> This patch makes rtld emulator in cross prelink use ld.so's name as it is encoded in PT_INTERP header.
>>>> 
>>>> Currently, rtld emulator returns "lib/ld.so.1" for runtime linker's name, but the linker actually expects "/lib/ld.so.1" -- that one slash at the beginning causes prelink checks done by the runtime linker to fail and not use prelink information.
>>>> 
>>>> The runtime linker sets up a map for itself under the name stored in PT_INTERP header of the executable, and this patch makes rtld emulator follow the suit.
>>>> 
>>>> I have tested this patch using a different version of rtld emulator (the one that CodeSourcery / Mentor maintains), but the function in question is the same in both, so this patch is also relevant for Yocto's prelink.
>>>> 
>>>> Any comments?  Please merge at your leisure.
>>> 
>>> prelinker currently checks that the ld.so name matches what it's expecting for any given arch in the PL_ARCH structure.  Does this change any of that behavior?  Or does it simply change the internal prelink-rtld behavior so that it the prelink-rtld acts as if it's name is the PT_INTERP element?
>> 
>> It is the latter.  Only behavior of prelink-rtld is change to the effect that it outputs "/lib/ld.so.1 ->  /lib/ld.so.1 ..." as executable's dependency.
>> 
>> Forgot to mention: the dependency on ld.so.1 [usually] comes from libdl.so, which is, probably, why this bug wasn't noticed before.
> 
> Thanks, I think I understand what is going on now.  I'll look into getting this merged into the cross prelinker later today or tomorrow.

Mark,

This patch is still not merged to cross-prelink, did you encounter a problem with it?

Thank you,

--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics

  reply	other threads:[~2012-05-26  3:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 19:28 Maxim Kuvyrkov
2012-04-10 19:46 ` Mark Hatle
2012-04-10 19:57   ` Maxim Kuvyrkov
2012-04-10 20:23     ` Mark Hatle
2012-05-26  3:42       ` Maxim Kuvyrkov [this message]
2012-05-29 15:17         ` Mark Hatle
2012-06-27 22:34           ` Maxim Kuvyrkov
2012-06-28  2:29             ` Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10862750-7E5E-4B2C-9FEF-1EADEB197044@codesourcery.com \
    --to=maxim@codesourcery.com \
    --cc=mark.hatle@windriver.com \
    --cc=prelink@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).