From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26396 invoked by alias); 4 Dec 2007 16:12:44 -0000 Received: (qmail 26388 invoked by uid 22791); 4 Dec 2007 16:12:43 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Dec 2007 16:12:32 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0D0559833F for ; Tue, 4 Dec 2007 16:12:30 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id E175098100 for ; Tue, 4 Dec 2007 16:12:29 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IzaNp-00026i-72 for prelink@sourceware.org; Tue, 04 Dec 2007 11:12:29 -0500 Date: Tue, 04 Dec 2007 16:12:00 -0000 From: Daniel Jacobowitz To: prelink@sourceware.org Subject: More helpful error message during path walk Message-ID: <20071204161229.GA7758@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact prelink-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: prelink-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00002.txt.bz2 I don't remember if I've sent this before, but I couldn't find a record of it. I was working on a filesystem where nftw64 failed (maybe permissions? bad symlink? I don't remember, sorry), and nothing eventually led to an error message. So prelink failed to prelink some files I expected it to, but didn't say why not. The obvious patch made it much clearer what was happening. -- Daniel Jacobowitz CodeSourcery 2007-04-30 Daniel Jacobowitz * gather.c (gather_object): Print an error if nftw64 fails. Index: gather.c =================================================================== --- gather.c (revision 152) +++ gather.c (working copy) @@ -1004,6 +1004,8 @@ gather_object (const char *name, int der ++implicit; ret = nftw64 (name, gather_func, 20, flags | FTW_ACTIONRETVAL); --implicit; + if (ret < 0) + error (0, errno, "Failed searching %s", name); #ifndef HAVE_FTW_ACTIONRETVAL free (blacklist_dir); blacklist_dir = NULL;