From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29661 invoked by alias); 4 Dec 2007 16:24:21 -0000 Received: (qmail 29653 invoked by uid 22791); 4 Dec 2007 16:24:21 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Dec 2007 16:24:16 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lB4GOBmc029626; Tue, 4 Dec 2007 11:24:11 -0500 Received: from devserv.devel.redhat.com (devserv.devel.redhat.com [10.10.36.72]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lB4GOAnf006881; Tue, 4 Dec 2007 11:24:10 -0500 Received: from devserv.devel.redhat.com (localhost.localdomain [127.0.0.1]) by devserv.devel.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id lB4GOAoJ017223; Tue, 4 Dec 2007 11:24:10 -0500 Received: (from jakub@localhost) by devserv.devel.redhat.com (8.12.11.20060308/8.12.11/Submit) id lB4GOAPa017221; Tue, 4 Dec 2007 11:24:10 -0500 Date: Tue, 04 Dec 2007 16:24:00 -0000 From: Jakub Jelinek To: Daniel Jacobowitz Cc: prelink@sourceware.org Subject: Re: More helpful error message during path walk Message-ID: <20071204162410.GC16835@devserv.devel.redhat.com> Reply-To: Jakub Jelinek References: <20071204161229.GA7758@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071204161229.GA7758@caradoc.them.org> User-Agent: Mutt/1.4.1i X-IsSubscribed: yes Mailing-List: contact prelink-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: prelink-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00004.txt.bz2 On Tue, Dec 04, 2007 at 11:12:29AM -0500, Daniel Jacobowitz wrote: > I don't remember if I've sent this before, but I couldn't find a > record of it. I was working on a filesystem where nftw64 failed > (maybe permissions? bad symlink? I don't remember, sorry), and > nothing eventually led to an error message. So prelink failed to > prelink some files I expected it to, but didn't say why not. The > obvious patch made it much clearer what was happening. I'd worry about ENOENT errors, because prelink.conf generally contains a bunch of dirs that may not be present and that should be silent. But in that case already stat64 at the beginning of gather_object should fail with ENOENT and when implicit this should silently return, so I guess the patch is ok. Please commit it. > 2007-04-30 Daniel Jacobowitz > > * gather.c (gather_object): Print an error if nftw64 fails. Jakub