From: Daniel Jacobowitz <drow@false.org>
To: prelink@sourceware.org
Subject: Re: More helpful error message during path walk
Date: Tue, 04 Dec 2007 16:43:00 -0000 [thread overview]
Message-ID: <20071204164316.GA15848@caradoc.them.org> (raw)
In-Reply-To: <20071204162410.GC16835@devserv.devel.redhat.com>
On Tue, Dec 04, 2007 at 11:24:10AM -0500, Jakub Jelinek wrote:
> I'd worry about ENOENT errors, because prelink.conf generally contains
> a bunch of dirs that may not be present and that should be silent.
> But in that case already stat64 at the beginning of gather_object
> should fail with ENOENT and when implicit this should silently return,
> so I guess the patch is ok. Please commit it.
I verified that it doesn't cause a problem in that case. nftw64
calls the gather function for inaccessible directories, too, so that
isn't affected. So mostly this has no effect except in whatever case
prompted me to write it. Really must take better notes about these
things...
Thanks.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-12-04 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 16:12 Daniel Jacobowitz
2007-12-04 16:24 ` Jakub Jelinek
2007-12-04 16:43 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204164316.GA15848@caradoc.them.org \
--to=drow@false.org \
--cc=prelink@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).