From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <prelink-return-8-listarch-prelink=sourceware.org@sourceware.org>
Received: (qmail 2085 invoked by alias); 16 May 2008 18:31:15 -0000
Received: (qmail 2006 invoked by uid 22791); 16 May 2008 18:30:57 -0000
X-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 16 May 2008 18:30:37 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 58658983F9 	for <prelink@sourceware.org>; Fri, 16 May 2008 18:30:35 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 32BEB983D6 	for <prelink@sourceware.org>; Fri, 16 May 2008 18:30:35 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1Jx4hO-00073A-0p 	for prelink@sourceware.org; Fri, 16 May 2008 14:30:34 -0400
Date: Fri, 16 May 2008 18:31:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: prelink@sourceware.org
Subject: Re: Do not crash on corrupt symbol tables
Message-ID: <20080516183033.GA26988@caradoc.them.org>
References: <20071204161425.GA8129@caradoc.them.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20071204161425.GA8129@caradoc.them.org>
User-Agent: Mutt/1.5.17 (2008-05-11)
X-IsSubscribed: yes
Mailing-List: contact prelink-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <prelink.sourceware.org>
List-Subscribe: <mailto:prelink-subscribe@sourceware.org>
List-Post: <mailto:prelink@sourceware.org>
List-Help: <mailto:prelink-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: prelink-owner@sourceware.org
X-SW-Source: 2008-q2/txt/msg00000.txt.bz2

On Tue, Dec 04, 2007 at 11:14:25AM -0500, Daniel Jacobowitz wrote:
> I have a library with a very corrupt symbol table.  It kills the
> prelinker, because some sections have not yet been moved in dso->scn
> when we go to close the corrupt file, so it tries to free some mmapped
> pointers.  This patch lets everything else in the filesystem be
> prelinked normally.

Ping?

> 2007-12-04  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	* dso.c (reopen_dso): Update dso->scn and dso->shdr before
> 	adjusting sections.
> 
> ---
>  src/dso.c |    4 ++++
>  1 files changed, 4 insertions(+)
> 
> Index: prelink-20061211/src/dso.c
> ===================================================================
> --- prelink-20061211.orig/src/dso.c	2007-12-04 07:36:25.000000000 -0800
> +++ prelink-20061211/src/dso.c	2007-12-04 08:05:40.000000000 -0800
> @@ -936,6 +936,10 @@ reopen_dso (DSO *dso, struct section_mov
>      {
>        dso->scn[i] = elf_getscn (dso->elf, i);
>        gelfx_getshdr (dso->elf, dso->scn[i], dso->shdr + i);
> +    }
> +
> +  for (i = 1; i < move->new_shnum; i++)
> +    {
>        if (move->new_to_old[i] == -1)
>  	continue;
>        if (dso->move
> 

-- 
Daniel Jacobowitz
CodeSourcery