public inbox for prelink@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Catherine Moore <clm@codesourcery.com>,
	prelink@sourceware.org, 	rdsandiford@googlemail.com
Subject: Re: [patch] Add support for new mips relocs
Date: Wed, 03 Dec 2008 20:29:00 -0000	[thread overview]
Message-ID: <20081203202906.GA30422@caradoc.them.org> (raw)
In-Reply-To: <87myfdc946.fsf@firetop.home>

On Wed, Dec 03, 2008 at 08:11:05PM +0000, Richard Sandiford wrote:
> Oh, OK.  So an old glibc will still work with old objects?
> 
> (Sorry, it's been so long since I wrote this stuff, and I don't
> really have time to refresh my memory.  It might well be that,
> because I had to return something in the default case, I thought
> I might as well return the more accurate RTYPE_CLASS_PLT,
> even if it didn't make any practical difference.)

I'm pretty sure that the result will still be correct.

There's only one use in all of prelink that I can find: in the C++
vtable optimizer.  I don't fully understand that code, but it seems
quite possible the patch will pessimize some binaries that would
previously have had fewer conflicts.  Not sure what to do about
that... adjust the check at cxx.c:334 to handle STO_MIPS_PLT
if EM_MIPS?


-- 
Daniel Jacobowitz
CodeSourcery

  reply	other threads:[~2008-12-03 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-03 18:46 Catherine Moore
2008-12-03 19:37 ` Richard Sandiford
2008-12-03 20:03   ` Daniel Jacobowitz
2008-12-03 20:12     ` Richard Sandiford
2008-12-03 20:29       ` Daniel Jacobowitz [this message]
2008-12-16 16:27         ` Daniel Jacobowitz
2009-01-12 17:28           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081203202906.GA30422@caradoc.them.org \
    --to=drow@false.org \
    --cc=clm@codesourcery.com \
    --cc=prelink@sourceware.org \
    --cc=rdsandiford@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).