From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11100 invoked by alias); 7 May 2013 12:34:07 -0000 Mailing-List: contact prelink-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: prelink-owner@sourceware.org Received: (qmail 11089 invoked by uid 89); 7 May 2013 12:34:06 -0000 X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 07 May 2013 12:34:05 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UZh5m-00012c-Gz from Tom_deVries@mentor.com ; Tue, 07 May 2013 05:34:02 -0700 Received: from SVR-IES-FEM-02.mgc.mentorg.com ([137.202.0.106]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 7 May 2013 05:34:02 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.2.247.3; Tue, 7 May 2013 13:33:59 +0100 Message-ID: <5188F4B0.7050309@mentor.com> Date: Tue, 07 May 2013 12:34:00 -0000 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jakub Jelinek CC: Subject: [PATCH] Add LINKOPTS to CCLINK and CXXLINK in testsuite/Makefile.am Content-Type: multipart/mixed; boundary="------------010209090407090303050209" X-Virus-Found: No X-SW-Source: 2013-q2/txt/msg00000.txt.bz2 --------------010209090407090303050209 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Content-length: 872 Jakub, this patch allows me to run all the tests successfully on x86_64 with LINKOPTS="-Wl,--no-as-needed" set in the environment. When I built prelink on x86_64 and ran the tests, I found I had a number of test failures. I investigated a failure (tls5) and found that my compiler uses --as-needed by default, and that using --no-as-needed allowed the test to pass. Rerunning with LINKOPTS="-Wl,--no-as-needed" allowed 3 more tests to pass, but still a number of tests were failing. I investigated another test (cycle1) and found the reason for failure was that LINKOPTS was not passed to CCLINK and CXXLINK in the makefile. This patch fixes that. Build and tested on x86_64. OK? Thanks, - Tom 2013-05-07 Tom de Vries * testsuite/Makefile.am (TESTS_ENVIRONMENT): Add LINKOPTS to CCLINK and CXXLINK. * testsuite/Makefile.in: Propagate. --------------010209090407090303050209 Content-Type: text/x-patch; name="cclink.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cclink.patch" Content-length: 1554 diff --git a/trunk/testsuite/Makefile.am b/trunk/testsuite/Makefile.am index b80eb48..5b22934 100644 --- a/trunk/testsuite/Makefile.am +++ b/trunk/testsuite/Makefile.am @@ -19,8 +19,8 @@ TESTS = movelibs.sh \ undosyslibs.sh TESTS_ENVIRONMENT = \ PRELINK="../src/prelink -c ./prelink.conf -C ./prelink.cache --ld-library-path=. --dynamic-linker=`echo ./ld*.so.*[0-9]`" \ - CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ - CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ + CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ + CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ $(SHELL) extra_DIST = $(TESTS) functions.sh diff --git a/trunk/testsuite/Makefile.in b/trunk/testsuite/Makefile.in index 84e0ea2..e3d48cb 100644 --- a/trunk/testsuite/Makefile.in +++ b/trunk/testsuite/Makefile.in @@ -115,8 +115,8 @@ TESTS = movelibs.sh \ TESTS_ENVIRONMENT = \ PRELINK="../src/prelink -c ./prelink.conf -C ./prelink.cache --ld-library-path=. --dynamic-linker=`echo ./ld*.so.*[0-9]`" \ - CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ - CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ + CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ + CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \ $(SHELL) --------------010209090407090303050209--