public inbox for prelink@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <Tom_deVries@mentor.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: <prelink@sourceware.org>
Subject: Re: [PATCH] Add LINKOPTS to CCLINK and CXXLINK in testsuite/Makefile.am
Date: Tue, 07 May 2013 17:10:00 -0000	[thread overview]
Message-ID: <51893592.3060909@mentor.com> (raw)
In-Reply-To: <20130507144719.GF28963@tucnak.redhat.com>

On 07/05/13 16:47, Jakub Jelinek wrote:
> On Tue, May 07, 2013 at 04:42:18PM +0200, Tom de Vries wrote:
>> $ ld --version
>> GNU ld (GNU Binutils for Ubuntu) 2.22
>> ...
>>
>> I'll try to build and run the tests using a build of upstream binutils, and see
>> if that fixes it.
> 
> The only issue I was aware of were ifunc*.sh failures (caused by some
> recentish ifunc handling change in ld.bfd, fixed recently), but that was
> just a few months, and also another December 2012ish ld change that broke
> the --as-needed handling (the recent testsuite changes should fix that up).
> 

The failures where not due to ld, but due to ubuntu gcc, which passes
--as-needed to the linker by default.

Using a gcc build from upstream, all the tests pass.

The failures I saw can still be reproduced with upstream gcc by setting
--as-needed like this:
...
$ make check CC='gcc -Wl,--as-needed' CXX='g++ -Wl,--as-needed'
...

I think the changes in the testsuite that you were referring to earlier in this
thread were related to --add-needed/--no-add-needed, not
--as-needed/--no-as-needed. The option names -add-needed/--no-add-needed have
already been deprecated for being too much like -as-needed/--no-as-needed.

Thanks,
- Tom

      reply	other threads:[~2013-05-07 17:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07 12:34 Tom de Vries
2013-05-07 12:40 ` Jakub Jelinek
2013-05-07 14:22   ` Tom de Vries
2013-05-07 14:28     ` Jakub Jelinek
2013-05-07 14:42       ` Tom de Vries
2013-05-07 14:47         ` Jakub Jelinek
2013-05-07 17:10           ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51893592.3060909@mentor.com \
    --to=tom_devries@mentor.com \
    --cc=jakub@redhat.com \
    --cc=prelink@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).