public inbox for prelink@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Add LINKOPTS to CCLINK and CXXLINK in testsuite/Makefile.am
@ 2013-05-07 12:34 Tom de Vries
  2013-05-07 12:40 ` Jakub Jelinek
  0 siblings, 1 reply; 7+ messages in thread
From: Tom de Vries @ 2013-05-07 12:34 UTC (permalink / raw)
  To: Jakub Jelinek; +Cc: prelink

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

Jakub,

this patch allows me to run all the tests successfully on x86_64 with
LINKOPTS="-Wl,--no-as-needed" set in the environment.

When I built prelink on x86_64 and ran the tests, I found I had a number of test
failures. I investigated a failure (tls5) and found that my compiler uses
--as-needed by default, and that using --no-as-needed allowed the test to pass.

Rerunning with LINKOPTS="-Wl,--no-as-needed" allowed 3 more tests to pass, but
still a number of tests were failing. I investigated another test (cycle1) and
found the reason for failure was that LINKOPTS was not passed to CCLINK and
CXXLINK in the makefile.

This patch fixes that. Build and tested on x86_64.

OK?

Thanks,
- Tom

2013-05-07  Tom de Vries  <tom@codesourcery.com>

	* testsuite/Makefile.am (TESTS_ENVIRONMENT): Add LINKOPTS to CCLINK and
	CXXLINK.
	* testsuite/Makefile.in: Propagate.


[-- Attachment #2: cclink.patch --]
[-- Type: text/x-patch, Size: 1554 bytes --]

diff --git a/trunk/testsuite/Makefile.am b/trunk/testsuite/Makefile.am
index b80eb48..5b22934 100644
--- a/trunk/testsuite/Makefile.am
+++ b/trunk/testsuite/Makefile.am
@@ -19,8 +19,8 @@ TESTS = movelibs.sh \
 	undosyslibs.sh
 TESTS_ENVIRONMENT = \
 	PRELINK="../src/prelink -c ./prelink.conf -C ./prelink.cache --ld-library-path=. --dynamic-linker=`echo ./ld*.so.*[0-9]`" \
-	CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
-	CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
+	CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
+	CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
 	$(SHELL)
 
 extra_DIST = $(TESTS) functions.sh
diff --git a/trunk/testsuite/Makefile.in b/trunk/testsuite/Makefile.in
index 84e0ea2..e3d48cb 100644
--- a/trunk/testsuite/Makefile.in
+++ b/trunk/testsuite/Makefile.in
@@ -115,8 +115,8 @@ TESTS = movelibs.sh \
 
 TESTS_ENVIRONMENT = \
 	PRELINK="../src/prelink -c ./prelink.conf -C ./prelink.cache --ld-library-path=. --dynamic-linker=`echo ./ld*.so.*[0-9]`" \
-	CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
-	CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
+	CC="$(CC) $(LINKOPTS)" CCLINK="$(CC) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
+	CXX="$(CXX) $(LINKOPTS)" CXXLINK="$(CXX) $(LINKOPTS) -Wl,--dynamic-linker=`echo ./ld*.so.*[0-9]`" \
 	$(SHELL)
 
 


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-05-07 17:10 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 12:34 [PATCH] Add LINKOPTS to CCLINK and CXXLINK in testsuite/Makefile.am Tom de Vries
2013-05-07 12:40 ` Jakub Jelinek
2013-05-07 14:22   ` Tom de Vries
2013-05-07 14:28     ` Jakub Jelinek
2013-05-07 14:42       ` Tom de Vries
2013-05-07 14:47         ` Jakub Jelinek
2013-05-07 17:10           ` Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).