From: Richard Sandiford <rdsandiford@googlemail.com>
To: Catherine Moore <clm@codesourcery.com>
Cc: prelink@sourceware.org
Subject: Re: [patch] Add support for new mips relocs
Date: Wed, 03 Dec 2008 19:37:00 -0000 [thread overview]
Message-ID: <87r64pcapp.fsf@firetop.home> (raw)
In-Reply-To: <4936D3D3.6030306@codesourcery.com> (Catherine Moore's message of "Wed\, 03 Dec 2008 13\:45\:39 -0500")
Catherine Moore <clm@codesourcery.com> writes:
> *************** mips_reloc_class (int reloc_type)
> *** 890,903 ****
> {
> switch (reloc_type)
> {
> case R_MIPS_TLS_DTPMOD32:
> case R_MIPS_TLS_DTPREL32:
> case R_MIPS_TLS_TPREL32:
> return RTYPE_CLASS_TLS;
> default:
> ! /* MIPS lazy resolution stubs are local to the containing object,
> ! so SHN_UNDEF symbols never participate in symbol lookup. */
> ! return RTYPE_CLASS_PLT;
> }
> }
>
> --- 914,929 ----
> {
> switch (reloc_type)
> {
> + case R_MIPS_COPY:
> + return RTYPE_CLASS_COPY;
> + case R_MIPS_JUMP_SLOT:
> + return RTYPE_CLASS_PLT;
> case R_MIPS_TLS_DTPMOD32:
> case R_MIPS_TLS_DTPREL32:
> case R_MIPS_TLS_TPREL32:
> return RTYPE_CLASS_TLS;
> default:
> ! return RTYPE_CLASS_VALID;
> }
> }
>
I'm probably missing something, sorry, but how does the patch handle
the property mentioned in the original comment? Relocations must never
resolve to another object's (traditional) lazy-binding stub.
Richard
next prev parent reply other threads:[~2008-12-03 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 18:46 Catherine Moore
2008-12-03 19:37 ` Richard Sandiford [this message]
2008-12-03 20:03 ` Daniel Jacobowitz
2008-12-03 20:12 ` Richard Sandiford
2008-12-03 20:29 ` Daniel Jacobowitz
2008-12-16 16:27 ` Daniel Jacobowitz
2009-01-12 17:28 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r64pcapp.fsf@firetop.home \
--to=rdsandiford@googlemail.com \
--cc=clm@codesourcery.com \
--cc=prelink@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).