From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7921 invoked by alias); 3 Dec 2008 19:37:36 -0000 Received: (qmail 7910 invoked by uid 22791); 3 Dec 2008 19:37:36 -0000 X-Spam-Level: * X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ey-out-1920.google.com (HELO ey-out-1920.google.com) (74.125.78.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Dec 2008 19:36:40 +0000 Received: by ey-out-1920.google.com with SMTP id 4so1652857eyg.24 for ; Wed, 03 Dec 2008 11:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:mail-followup-to:cc :subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=1Q0tdss20k2fYUt8F26fsgo2XCqnGKWXvCJCNLcGb8U=; b=PGvuXX0eR7TNzxsLrcvk55sFcsDOag8zwavVBoyEFqC65AcLH7Bv8WroryILyn9MoI PjduJ+HwSYY1hIU3NMn3tORLLjAPDICJJlIng84McHziFNBOI6PnYS4ljJ28uhw9F8oK nbMLQtdymicHeo6blw9vTxtKLwuZ7fP+k4a7Q= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:mail-followup-to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=hxjZ3QFTiJCG6V+3jHUcjRH4Z8FCGt1huB8lBmcZ3O7IKM0L0css8wokibBl+DmNxB g/nW8ROqX9umiIGHEW0ln1x8dHDSof2AzyO0oomoUeGMyQoeDxtJDEcXXmKlHYJusECc 3qJ55hTBDlnt+YV1dx3PsY+nCHaWtyzGVRMyY= Received: by 10.210.58.13 with SMTP id g13mr2982664eba.81.1228332997600; Wed, 03 Dec 2008 11:36:37 -0800 (PST) Received: from localhost (79-75-71-222.dynamic.dsl.as9105.com [79.75.71.222]) by mx.google.com with ESMTPS id f3sm8174070nfh.2.2008.12.03.11.36.35 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 03 Dec 2008 11:36:36 -0800 (PST) From: Richard Sandiford To: Catherine Moore Mail-Followup-To: Catherine Moore ,prelink@sourceware.org, rdsandiford@googlemail.com Cc: prelink@sourceware.org Subject: Re: [patch] Add support for new mips relocs References: <4936D3D3.6030306@codesourcery.com> Date: Wed, 03 Dec 2008 19:37:00 -0000 In-Reply-To: <4936D3D3.6030306@codesourcery.com> (Catherine Moore's message of "Wed\, 03 Dec 2008 13\:45\:39 -0500") Message-ID: <87r64pcapp.fsf@firetop.home> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact prelink-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: prelink-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00002.txt.bz2 Catherine Moore writes: > *************** mips_reloc_class (int reloc_type) > *** 890,903 **** > { > switch (reloc_type) > { > case R_MIPS_TLS_DTPMOD32: > case R_MIPS_TLS_DTPREL32: > case R_MIPS_TLS_TPREL32: > return RTYPE_CLASS_TLS; > default: > ! /* MIPS lazy resolution stubs are local to the containing object, > ! so SHN_UNDEF symbols never participate in symbol lookup. */ > ! return RTYPE_CLASS_PLT; > } > } > > --- 914,929 ---- > { > switch (reloc_type) > { > + case R_MIPS_COPY: > + return RTYPE_CLASS_COPY; > + case R_MIPS_JUMP_SLOT: > + return RTYPE_CLASS_PLT; > case R_MIPS_TLS_DTPMOD32: > case R_MIPS_TLS_DTPREL32: > case R_MIPS_TLS_TPREL32: > return RTYPE_CLASS_TLS; > default: > ! return RTYPE_CLASS_VALID; > } > } > I'm probably missing something, sorry, but how does the patch handle the property mentioned in the original comment? Relocations must never resolve to another object's (traditional) lazy-binding stub. Richard