From: "Joseph S. Myers" <joseph@codesourcery.com>
To: prelink@sourceware.org
Subject: Fix MSB shift in prelink adjusting debug info
Date: Thu, 06 Aug 2009 23:52:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0908062346310.15815@digraph.polyomino.org.uk> (raw)
This patch fixes an incorrect shift by 58 instead of 56 when computing the
most significant byte when prelink adjusts debug info. Please commit if
OK.
This problem manifests itself as test failures for SPARC64 but not other
platforms I've tested, probably because the mmap_base setting for that
platform has a nonzero MSB and most others don't.
2009-08-06 Joseph Myers <joseph@codesourcery.com>
* src/dwarf2.c (dwarf2_write_le64, dwarf2_write_be64): Shift by 56
not 58 for MSB.
Index: src/dwarf2.c
===================================================================
--- src/dwarf2.c (revision 173)
+++ src/dwarf2.c (working copy)
@@ -115,7 +115,7 @@
p[4] = val >> 32;
p[5] = val >> 40;
p[6] = val >> 48;
- p[7] = val >> 58;
+ p[7] = val >> 56;
}
static void
@@ -139,7 +139,7 @@
p[3] = val >> 32;
p[2] = val >> 40;
p[1] = val >> 48;
- p[0] = val >> 58;
+ p[0] = val >> 56;
}
static struct
--
Joseph S. Myers
joseph@codesourcery.com
next reply other threads:[~2009-08-06 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:52 Joseph S. Myers [this message]
2009-08-07 6:15 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0908062346310.15815@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=prelink@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).