From: "Joseph S. Myers" <joseph@codesourcery.com>
To: prelink@sourceware.org
Subject: Old libelf.m4 change not committed
Date: Thu, 15 Oct 2009 17:14:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0910151703540.11613@digraph.polyomino.org.uk> (raw)
Prelink's aclocal.m4 appears to have been generated with a change to
m4/libelf.m4, below, that was never checked in. The consequence of this
is that if you make changes to prelink involving running aclocal to
regenerate aclocal.m4 and autoconf to regenerate configure, this change is
lost and the configure test fails to compile if the compiler has
_FORTIFY_SOURCE enabled, because of the missing argument to open.
If you apply this change, I couldn't fine the auto* versions to regenerate
the other checked in files exactly; they are autoconf 2.57, automake 1.6.3
and a libtool version that might be somewhere between 1.5 and 1.5.2 or a
patched version of 1.5 (1.5 seemed to generate the nearest version of
aclocal.m4). In any case, it is not necessary to regenerate any files
when checking in this patch, although regenerating the auto* machinery
with more recent versions of libtool, automake and autoconf ("autoreconf
--install --force" should be a reasonable start; it gives some warnings
that should perhaps be fixed) might be a good idea anyway.
Could you check in this patch (with or without any regeneration) if OK?
2009-10-15 Joseph Myers <joseph@codesourcery.com>
* m4/libelf.m4: Resync with version of code in aclocal.m4.
Index: m4/libelf.m4
===================================================================
--- m4/libelf.m4 (revision 175)
+++ m4/libelf.m4 (working copy)
@@ -73,7 +73,8 @@
Elf64_Addr val;
Elf_Scn *scn;
- fd = open ("conflibelftest", O_RDWR | O_CREAT | O_EXCL); if (fd == -1) exit (1);
+ fd = open ("conflibelftest", O_RDWR | O_CREAT | O_EXCL, 0600);
+ if (fd == -1) exit (1);
unlink ("conflibelftest");
if (write (fd, sparc64_elf, sizeof(sparc64_elf)) != sizeof(sparc64_elf))
exit (1);
--
Joseph S. Myers
joseph@codesourcery.com
reply other threads:[~2009-10-15 17:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0910151703540.11613@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=prelink@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).