From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15983 invoked by alias); 15 Oct 2009 17:14:36 -0000 Received: (qmail 15970 invoked by uid 22791); 15 Oct 2009 17:14:34 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Oct 2009 17:14:23 +0000 Received: (qmail 25150 invoked from network); 15 Oct 2009 17:14:21 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Oct 2009 17:14:21 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.69) (envelope-from ) id 1MyTu7-0005QL-Mh for prelink@sourceware.org; Thu, 15 Oct 2009 17:14:19 +0000 Date: Thu, 15 Oct 2009 17:14:00 -0000 From: "Joseph S. Myers" To: prelink@sourceware.org Subject: Old libelf.m4 change not committed Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact prelink-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: prelink-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00001.txt.bz2 Prelink's aclocal.m4 appears to have been generated with a change to m4/libelf.m4, below, that was never checked in. The consequence of this is that if you make changes to prelink involving running aclocal to regenerate aclocal.m4 and autoconf to regenerate configure, this change is lost and the configure test fails to compile if the compiler has _FORTIFY_SOURCE enabled, because of the missing argument to open. If you apply this change, I couldn't fine the auto* versions to regenerate the other checked in files exactly; they are autoconf 2.57, automake 1.6.3 and a libtool version that might be somewhere between 1.5 and 1.5.2 or a patched version of 1.5 (1.5 seemed to generate the nearest version of aclocal.m4). In any case, it is not necessary to regenerate any files when checking in this patch, although regenerating the auto* machinery with more recent versions of libtool, automake and autoconf ("autoreconf --install --force" should be a reasonable start; it gives some warnings that should perhaps be fixed) might be a good idea anyway. Could you check in this patch (with or without any regeneration) if OK? 2009-10-15 Joseph Myers * m4/libelf.m4: Resync with version of code in aclocal.m4. Index: m4/libelf.m4 =================================================================== --- m4/libelf.m4 (revision 175) +++ m4/libelf.m4 (working copy) @@ -73,7 +73,8 @@ Elf64_Addr val; Elf_Scn *scn; - fd = open ("conflibelftest", O_RDWR | O_CREAT | O_EXCL); if (fd == -1) exit (1); + fd = open ("conflibelftest", O_RDWR | O_CREAT | O_EXCL, 0600); + if (fd == -1) exit (1); unlink ("conflibelftest"); if (write (fd, sparc64_elf, sizeof(sparc64_elf)) != sizeof(sparc64_elf)) exit (1); -- Joseph S. Myers joseph@codesourcery.com