From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pthreads-win32-return-872-listarch-pthreads-win32=sources.redhat.com@sources.redhat.com>
Received: (qmail 11608 invoked by alias); 3 Nov 2004 13:18:05 -0000
Mailing-List: contact pthreads-win32-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:pthreads-win32-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/pthreads-win32/>
List-Post: <mailto:pthreads-win32@sources.redhat.com>
List-Help: <mailto:pthreads-win32-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: pthreads-win32-owner@sources.redhat.com
Received: (qmail 11595 invoked from network); 3 Nov 2004 13:18:03 -0000
Received: from unknown (HELO mail.broadpark.no) (217.13.4.2)
  by sourceware.org with SMTP; 3 Nov 2004 13:18:03 -0000
Received: from pcgv (111.80-202-228.nextgentel.com [80.202.228.111])
	by mail.broadpark.no (Postfix) with SMTP id 965663099
	for <pthreads-win32@sources.redhat.com>; Wed,  3 Nov 2004 14:18:52 +0100 (MET)
Message-ID: <0b0b01c4c1a7$8a2fe3b0$0600000a@broadpark.no>
From: "Gisle Vanem" <giva@bgnett.no>
To: "pthreads-win32" <pthreads-win32@sources.redhat.com>
Subject: snap-2004-11-03 breakage
Date: Wed, 03 Nov 2004 13:18:00 -0000
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004/txt/msg00127.txt.bz2

snap-2004-11-03 breaks a lot of applications by the way 'pthread_t' is 
defined:

typedef struct {
    void * p;                   /* Pointer to actual object */
    unsigned int x;             /* Extra information - reuse count etc */
} ptw32_handle_t;

typedef ptw32_handle_t pthread_t;

Code like (from Ettercap)
  pthread_t pid = ec_thread_getpid("golem");
  if (pid != 0)
    ec_thread_destroy(pid);

no longer works; you cannot compare a struct against 0.

I'm not sure you really meant to do that or if the typedef should be
typedef ptw32_handle_t *pthread_t;

--gv