From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7778 invoked by alias); 19 Nov 2004 07:47:14 -0000 Mailing-List: contact pthreads-win32-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: pthreads-win32-owner@sources.redhat.com Received: (qmail 7654 invoked from network); 19 Nov 2004 07:47:08 -0000 Received: from unknown (HELO localhost.localdomain) (202.147.68.14) by sourceware.org with SMTP; 19 Nov 2004 07:47:08 -0000 Received: from [202.147.87.136] (helo=callisto.canberra.edu.au) by localhost.localdomain with esmtp (Exim 3.35 #1 (Debian)) id 1CV3U3-0002sG-00 for ; Fri, 19 Nov 2004 18:47:07 +1100 Message-ID: <419DA4F5.1070904@callisto.canberra.edu.au> Date: Fri, 19 Nov 2004 07:47:00 -0000 From: Ross Johnson Reply-To: rpj@callisto.canberra.edu.au User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040421 MIME-Version: 1.0 To: "'pthreads-win32@sources.redhat.com'" Subject: Re: pthread_cond_broadcast(...) leads to a deadlock References: <715D092C2A9AD411B4DD006097C6EE8401482C8F@EXCHSVR> In-Reply-To: <715D092C2A9AD411B4DD006097C6EE8401482C8F@EXCHSVR> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004/txt/msg00155.txt.bz2 Alex Kotliarov wrote: > - any reason why pthread_mutex_lock (cleanup_args->mutexPtr) was moved >to the top? Algorithm 8A has this line at the bottom of > ptw32_cond_wait_cleanup() > > > I read, in an authoritative forum, that the external mutex is required to be held during cv cancel cleanup. The cleanup routine is also part of the normal cv wake-up logic but the change passed the test suite and so it seemed safe. I don't know if it's still a potential conformance problem, but this change obviously wasn't the solution. The current version of pthread_cond_wait.c with the change undone is in CVS: http://sources.redhat.com/cgi-bin/cvsweb.cgi/~checkout~/pthreads/pthread_cond_wait.c?rev=1.8&content-type=text/plain&cvsroot=pthreads-win32 Apologies. Ross > Thanks, > > Alexander Kotliarov. > > >