From: Ramiro Polla <ramiro@lisha.ufsc.br>
To: pthreads-win32@sourceware.org
Subject: Re: pthreads-win32 2.8.0, stack alignment, and SSE code
Date: Sun, 05 Oct 2008 13:41:00 -0000 [thread overview]
Message-ID: <48E8C3B8.2080709@lisha.ufsc.br> (raw)
In-Reply-To: <48E8B399.502@yahoo.fr>
Sébastien Kunz-Jacques wrote:
> Hi,
>
> I encountered problems with SSE code compiled with recent mingw GCC
> (4.3.2, TDM release, http://www.tdragon.net/recentgcc/) and using
> pthreads 2.8.0. After inverstigation, crashes occured because the code
> was trying to read operands on the stack, assuming the stack was 16-byte
> aligned as is the case in the main thread (the main function aligns the
> stack and alignment is maintained during each function call). I solved
> the issue with a very simple patch that uses some GCC wizardry to force
> stack realignment upon entry in a new thread:
>
> --- ptw32_threadStart.c Sun May 15 17:28:27 2005
> +++ ptw32_threadStart.c Mon Sep 29 21:28:16 2008
> @@ -116,6 +116,9 @@
>
> #endif
>
> +#if defined(__GNUC__) && (__GNUC__ > 4 || __GNUC__ == 4 &&
> __GNUC_MINOR__>1)
> +__attribute__((force_align_arg_pointer))
> +#endif
> #if ! defined (__MINGW32__) || (defined (__MSVCRT__) && ! defined
> (__DMC__))
> unsigned
> __stdcall
>
>
> The attribute force_align_arg_pointer should be added to every function
> that is called with a stack with insufficient alignment; as far as I am
> concerned doing this for threadStart only solved my problems. Maybe this
> small patch could be added to the pthread code?
I think that's related to:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37216
So I think this patch shouldn't be applied to pthreads-win32, and people
should rather use another version of MinGW (or unset automatic SSE code,
if that makes any sense).
Ramiro Polla
next prev parent reply other threads:[~2008-10-05 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-05 12:32 Sébastien Kunz-Jacques
2008-10-05 13:41 ` Ramiro Polla [this message]
2008-10-05 14:47 ` Sébastien Kunz-Jacques
2008-10-05 18:27 ` Ramiro Polla
2008-10-05 18:52 ` Sébastien Kunz-Jacques
2008-10-05 19:25 ` Ramiro Polla
2008-10-05 20:12 ` Sébastien Kunz-Jacques
2008-10-05 22:42 ` Ramiro Polla
2008-10-09 13:14 ` Ross Johnson
2008-10-09 19:51 ` Sébastien Kunz-Jacques
2008-10-23 5:57 ` Sébastien Kunz-Jacques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E8C3B8.2080709@lisha.ufsc.br \
--to=ramiro@lisha.ufsc.br \
--cc=pthreads-win32@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).