From: ralph engels <ralphengels@gmail.com>
To: pthreads-win32@sourceware.org
Subject: Submitting patches ?
Date: Sat, 19 Mar 2016 22:12:00 -0000 [thread overview]
Message-ID: <56EDCED4.9050004@gmail.com> (raw)
In-Reply-To: <1458421807.60620.ezmlm@sourceware.org>
Hello.
After some brainstorming and some help from a mingw.org user we managed
to get gcc building again with pthreads-w32. Theres a few changes
needed, first and foremost windows.h must not be included in pthread.h,
i used a guard to only allow it at build time but it should newer be
allowed if we want to do this correctly since it breaks gcc macros.
Secondly the check for __MINGW64__ is wrong since __MINGW64__ ==
__MINGW32__ if you want to distinguish the builds for the mingw-w64
compiler the correct define is __MINGW64_VERSION_MAJOR.
Rest of the changes are against gcc itself and have been pushed to the
gcc dev team.
Im not sure where to submit patches for pthreads-w32 since the
repository is read only,
but i can forward them to you if you prefer it that way.
Let me know which option would be preferable.
Regards Ralph Engels
parent reply other threads:[~2016-03-19 22:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1458421807.60620.ezmlm@sourceware.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EDCED4.9050004@gmail.com \
--to=ralphengels@gmail.com \
--cc=pthreads-win32@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).