From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pthreads-win32-return-941-listarch-pthreads-win32=sources.redhat.com@sources.redhat.com>
Received: (qmail 12951 invoked by alias); 5 Mar 2005 13:31:30 -0000
Mailing-List: contact pthreads-win32-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:pthreads-win32-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/pthreads-win32/>
List-Post: <mailto:pthreads-win32@sources.redhat.com>
List-Help: <mailto:pthreads-win32-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: pthreads-win32-owner@sources.redhat.com
Received: (qmail 12820 invoked from network); 5 Mar 2005 13:31:24 -0000
Received: from unknown (HELO rproxy.gmail.com) (64.233.170.204)
  by sourceware.org with SMTP; 5 Mar 2005 13:31:24 -0000
Received: by rproxy.gmail.com with SMTP id c51so755988rne
        for <pthreads-win32@sources.redhat.com>; Sat, 05 Mar 2005 05:31:24 -0800 (PST)
Received: by 10.38.65.21 with SMTP id n21mr3053rna;
        Sat, 05 Mar 2005 05:31:24 -0800 (PST)
Received: by 10.38.75.68 with HTTP; Sat, 5 Mar 2005 05:31:24 -0800 (PST)
Message-ID: <acf63ee050305053177936d0b@mail.gmail.com>
Date: Sat, 05 Mar 2005 13:31:00 -0000
From: Dmitrii Sernii <bogolt@gmail.com>
Reply-To: Dmitrii Sernii <bogolt@gmail.com>
To: pthreads-win32@sources.redhat.com
Subject: Re: Handle leak when using pthread mutex with win32 api threads
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005/txt/msg00023.txt.bz2

> > >        static pthread_mutex_t mutex(PTHREAD_RECURSIVE_MUTEX_INITIALIZER);
> >
> > that line above is not thread safe.  you might initialize the same
> > mutex multiple times.  Not good.
> >
> 
> The handle leak comes about because, in pthreads-win32, pthread_mutex_t
> is only a pointer, and the actual mutex struct is malloced by the
> library, in this case, the first time you call pthread_mutex_lock().
> That is, the library just calls pthread_mutex_init() for you. Also, you
> must always call pthread_mutex_destroy() to clean up, just the same as
> if you had called pthread_mutex_init() yourself.

I've made small corrections in test sample, so now mutex initialised
only once, and i've added pthread_mutex_destroy() function call. But
the problem still remains.
Here is two test applications - one of them uses API threads, and the
other pthreads. Program with pthreads don't have any leaks, while
program with API threads produces lots of them.

//program with handle leaks
#include <pthread.h>
#include <windows.h>
#include <conio.h>

pthread_mutex_t mutex(PTHREAD_RECURSIVE_MUTEX_INITIALIZER);

DWORD WINAPI threadProc(void *param)
{
	pthread_mutex_lock(&mutex);
	pthread_mutex_unlock(&mutex);
	return 0;
}

void main()
{
	const int max_threads = 500;
	DWORD id;
	HANDLE th[max_threads];
	int i;
	for (i=0;i<max_threads;i++)
	th[i]=CreateThread(0,0,threadProc,0,0,&id);

	for (i=0;i<max_threads;i++)
	{
		WaitForSingleObject(th[i],INFINITE);
		CloseHandle(th[i]);
	}
	pthread_mutex_destroy(&mutex);
	getch();
}

==========================

//program without handle leaks
#include <pthread.h>
#include <windows.h>
#include <conio.h>


pthread_mutex_t mutex(PTHREAD_RECURSIVE_MUTEX_INITIALIZER);

void* threadProc(void *param)
{
	pthread_mutex_lock(&mutex);
	pthread_mutex_unlock(&mutex);
    return 0;
}

void main()
{
	const int max_threads = 500;
	DWORD id;
	pthread_t th[max_threads];
	int i;

	for (i=0;i<max_threads;i++)
			pthread_create(&(th[i]),0,threadProc,(void*)i);

	for (i=0;i<max_threads;i++)
		pthread_join(th[i],(void**)&id);

	pthread_mutex_destroy(&mutex);
	getch();
}

Best regards,
Dmitrii Sernii