From: Ramiro Polla <ramiro.polla@gmail.com>
To: pthreads-win32@sourceware.org
Subject: Winsock dependency.
Date: Mon, 19 Oct 2009 15:10:00 -0000 [thread overview]
Message-ID: <f460258d0910190809n5b9a05e2sdce5e9293dc37cd0@mail.gmail.com> (raw)
Hi,
A dependency to Winsock was introduced to pthreads-win32 in this commit:
2001-08-23 Phil Frisbie, Jr. <phil at hawksoft.com>
* tsd.c (pthread_getspecific): Preserve the last
winsock error [from WSAGetLastError()].
There was an unanswered reply that questions whether this was really necessary:
http://sourceware.org/ml/pthreads-win32/2001/msg00122.html
Does anyone have a reproducible testcase that triggers the error this
commit was supposed to fix?
I've tested on win98, xp and vista and I can't get GetTlsValue() to
touch WSA errors. The source code in Wine also only uses
SetLastError(), and not WSASetLastError().
If I understood correctly, this should only be a problem if the user does:
some_wsock_function()
some_pthread_function()
WSAGetLastError()
In the case where people check for errors right after calling a wsock
function this shouldn't be a problem, right?
Ramiro Polla
next reply other threads:[~2009-10-19 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 15:10 Ramiro Polla [this message]
2009-10-19 20:14 ` Phil Frisbie, Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f460258d0910190809n5b9a05e2sdce5e9293dc37cd0@mail.gmail.com \
--to=ramiro.polla@gmail.com \
--cc=pthreads-win32@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).