From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14373 invoked by alias); 16 Jan 2003 17:33:45 -0000 Mailing-List: contact rda-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rda-owner@sources.redhat.com Received: (qmail 14044 invoked from network); 16 Jan 2003 17:32:02 -0000 Date: Thu, 16 Jan 2003 17:33:00 -0000 From: Kevin Buettner Message-Id: <1030116173139.ZM28429@localhost.localdomain> X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera) To: rda@sources.redhat.com Subject: [PATCH] Fix some minor problems in lib/gdbserv-state.c MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-q1/txt/msg00000.txt.bz2 I've just committed the following patch: * lib/gdbserv-state.c (do_status_packet, gdbserv_data_packet): Fix memset() calls - the arguments were in the wrong order. (gdbserv_data_packet): Check return value from get_reg() call. Index: lib/gdbserv-state.c =================================================================== RCS file: /cvs/src/src/rda/lib/gdbserv-state.c,v retrieving revision 1.1 diff -u -p -r1.1 gdbserv-state.c --- lib/gdbserv-state.c 28 Aug 2002 01:22:28 -0000 1.1 +++ lib/gdbserv-state.c 16 Jan 2003 17:23:30 -0000 @@ -237,7 +237,7 @@ do_status_packet (struct gdbserv *gdbser if (sizeof_reg > 0) gdbserv->target->get_reg (gdbserv, reg_nr, ®); else - memset (®, sizeof (reg), 0); + memset (®, 0, sizeof (reg)); gdbserv->target->output_reg (gdbserv, ®, len); gdbserv_output_char (gdbserv, ';'); } @@ -747,9 +747,14 @@ gdbserv_data_packet (struct gdbserv *gdb long sizeof_reg = gdbserv->target->sizeof_reg (gdbserv, reg_nr); long len = (sizeof_reg < 0 ? -sizeof_reg : sizeof_reg); if (sizeof_reg > 0) - gdbserv->target->get_reg (gdbserv, reg_nr, ®); + { + int status; + status = gdbserv->target->get_reg (gdbserv, reg_nr, ®); + if (status < 0) + memset (®, 0, sizeof (reg)); + } else - memset (®, sizeof (reg), 0); + memset (®, 0, sizeof (reg)); gdbserv->target->output_reg (gdbserv, ®, len); } }