From: Alan Modra <amodra@bigpond.net.au>
To: binutils@sourceware.org, Steve Ellcey <sje@cup.hp.com>,
gdb-patches@sourceware.org, rda@sourceware.org
Subject: Re: changes in 'intl'
Date: Fri, 23 Jun 2006 06:03:00 -0000 [thread overview]
Message-ID: <20060623060312.GF4388@bubble.grove.modra.org> (raw)
In-Reply-To: <20060531153301.GA17450@nevyn.them.org>
On Wed, May 31, 2006 at 11:33:02AM -0400, Daniel Jacobowitz wrote:
> Index: binutils/ChangeLog
> 2006-05-31 Daniel Jacobowitz <dan@codesourcery.com>
>
> * Makefile.am: Replace INTLLIBS with LIBINTL everywhere. Add
> DEPENDENCIES variables for every program.
This results in libbfd, libopcodes, and libiberty dependencies being
omitted. If you specify *_DEPENDENCIES variables, they need to list
*all* dependencies. A similar problem occurs if you try to add empty
rules for the exe files like
addr2line$(EXEEXT): $(LIBINTL_DEP)
ar$(EXEEXT): $(LIBINTL_DEP)
..
Automake then decides not to add its own rules. :-(
This patch isn't very nice, but I'm not inclined to delve into automake
to find a more elegant solution.
* Makefile.am (*_DEPENDENCIES): Add missing dependencies.
* Makefile.in: Regenerate.
Index: binutils/Makefile.am
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.74
diff -u -p -r1.74 Makefile.am
--- binutils/Makefile.am 31 May 2006 15:14:35 -0000 1.74
+++ binutils/Makefile.am 23 Jun 2006 05:52:18 -0000
@@ -182,24 +182,24 @@ installcheck:
# There's no global DEPENDENCIES. So, we must explicitly list everything
# which depends on libintl, since we don't know whether LIBINTL_DEP will be
# non-empty until configure time. Ugh!
-size_DEPENDENCIES = $(LIBINTL_DEP)
-objdump_DEPENDENCIES = $(LIBINTL_DEP)
-nm_new_DEPENDENCIES = $(LIBINTL_DEP)
-ar_DEPENDENCIES = $(LIBINTL_DEP)
-strings_DEPENDENCIES = $(LIBINTL_DEP)
-strip_new_DEPENDENCIES = $(LIBINTL_DEP)
-ranlib_DEPENDENCIES = $(LIBINTL_DEP)
-cxxfilt_DEPENDENCIES = $(LIBINTL_DEP)
-objcopy_DEPENDENCIES = $(LIBINTL_DEP)
-nlmconv_DEPENDENCIES = $(LIBINTL_DEP)
-srconv_DEPENDENCIES = $(LIBINTL_DEP)
-sysdump_DEPENDENCIES = $(LIBINTL_DEP)
-coffdump_DEPENDENCIES = $(LIBINTL_DEP)
-dlltool_DEPENDENCIES = $(LIBINTL_DEP)
-windres_DEPENDENCIES = $(LIBINTL_DEP)
-addr2line_DEPENDENCIES = $(LIBINTL_DEP)
-readelf_DEPENDENCIES = $(LIBINTL_DEP)
-dllwrap_DEPENDENCIES = $(LIBINTL_DEP)
+size_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+objdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) $(OPCODES)
+nm_new_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+ar_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+strings_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+strip_new_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+ranlib_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+cxxfilt_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+objcopy_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+nlmconv_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+srconv_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+sysdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+coffdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+dlltool_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+windres_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@
+addr2line_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB)
+readelf_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY)
+dllwrap_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY)
LDADD = $(BFDLIB) $(LIBIBERTY) $(LIBINTL)
--
Alan Modra
IBM OzLabs - Linux Technology Centre
next prev parent reply other threads:[~2006-06-23 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4475B7AD.46E1073E@dessent.net>
[not found] ` <20060525144537.GA1017@nevyn.them.org>
[not found] ` <20060525174240.GA5632@nevyn.them.org>
2006-05-25 22:49 ` Daniel Jacobowitz
2006-05-31 15:33 ` Daniel Jacobowitz
2006-06-23 6:03 ` Alan Modra [this message]
2006-07-17 16:21 ` Jakub Jelinek
2006-07-17 16:31 ` Daniel Jacobowitz
2006-07-17 20:07 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623060312.GF4388@bubble.grove.modra.org \
--to=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=rda@sourceware.org \
--cc=sje@cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).