From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14351 invoked by alias); 23 Jun 2006 06:03:19 -0000 Received: (qmail 14330 invoked by uid 22791); 23 Jun 2006 06:03:18 -0000 X-Spam-Status: No, hits=-0.3 required=5.0 tests=AWL,BAYES_00,DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_WHOIS,FORGED_RCVD_HELO,UPPERCASE_50_75 X-Spam-Check-By: sourceware.org Received: from omta03sl.mx.bigpond.com (HELO omta03sl.mx.bigpond.com) (144.140.92.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 23 Jun 2006 06:03:16 +0000 Received: from grove.modra.org ([60.226.255.233]) by omta03sl.mx.bigpond.com with ESMTP id <20060623060312.PFBE1089.omta03sl.mx.bigpond.com@grove.modra.org>; Fri, 23 Jun 2006 06:03:12 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id 5C5B71E6F97; Fri, 23 Jun 2006 15:33:12 +0930 (CST) Date: Fri, 23 Jun 2006 06:03:00 -0000 From: Alan Modra To: binutils@sourceware.org, Steve Ellcey , gdb-patches@sourceware.org, rda@sourceware.org Subject: Re: changes in 'intl' Message-ID: <20060623060312.GF4388@bubble.grove.modra.org> Mail-Followup-To: binutils@sourceware.org, Steve Ellcey , gdb-patches@sourceware.org, rda@sourceware.org References: <4475B7AD.46E1073E@dessent.net> <20060525144537.GA1017@nevyn.them.org> <20060525174240.GA5632@nevyn.them.org> <20060525224932.GA12464@nevyn.them.org> <20060531153301.GA17450@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060531153301.GA17450@nevyn.them.org> User-Agent: Mutt/1.4i Mailing-List: contact rda-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rda-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00003.txt.bz2 On Wed, May 31, 2006 at 11:33:02AM -0400, Daniel Jacobowitz wrote: > Index: binutils/ChangeLog > 2006-05-31 Daniel Jacobowitz > > * Makefile.am: Replace INTLLIBS with LIBINTL everywhere. Add > DEPENDENCIES variables for every program. This results in libbfd, libopcodes, and libiberty dependencies being omitted. If you specify *_DEPENDENCIES variables, they need to list *all* dependencies. A similar problem occurs if you try to add empty rules for the exe files like addr2line$(EXEEXT): $(LIBINTL_DEP) ar$(EXEEXT): $(LIBINTL_DEP) .. Automake then decides not to add its own rules. :-( This patch isn't very nice, but I'm not inclined to delve into automake to find a more elegant solution. * Makefile.am (*_DEPENDENCIES): Add missing dependencies. * Makefile.in: Regenerate. Index: binutils/Makefile.am =================================================================== RCS file: /cvs/src/src/binutils/Makefile.am,v retrieving revision 1.74 diff -u -p -r1.74 Makefile.am --- binutils/Makefile.am 31 May 2006 15:14:35 -0000 1.74 +++ binutils/Makefile.am 23 Jun 2006 05:52:18 -0000 @@ -182,24 +182,24 @@ installcheck: # There's no global DEPENDENCIES. So, we must explicitly list everything # which depends on libintl, since we don't know whether LIBINTL_DEP will be # non-empty until configure time. Ugh! -size_DEPENDENCIES = $(LIBINTL_DEP) -objdump_DEPENDENCIES = $(LIBINTL_DEP) -nm_new_DEPENDENCIES = $(LIBINTL_DEP) -ar_DEPENDENCIES = $(LIBINTL_DEP) -strings_DEPENDENCIES = $(LIBINTL_DEP) -strip_new_DEPENDENCIES = $(LIBINTL_DEP) -ranlib_DEPENDENCIES = $(LIBINTL_DEP) -cxxfilt_DEPENDENCIES = $(LIBINTL_DEP) -objcopy_DEPENDENCIES = $(LIBINTL_DEP) -nlmconv_DEPENDENCIES = $(LIBINTL_DEP) -srconv_DEPENDENCIES = $(LIBINTL_DEP) -sysdump_DEPENDENCIES = $(LIBINTL_DEP) -coffdump_DEPENDENCIES = $(LIBINTL_DEP) -dlltool_DEPENDENCIES = $(LIBINTL_DEP) -windres_DEPENDENCIES = $(LIBINTL_DEP) -addr2line_DEPENDENCIES = $(LIBINTL_DEP) -readelf_DEPENDENCIES = $(LIBINTL_DEP) -dllwrap_DEPENDENCIES = $(LIBINTL_DEP) +size_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +objdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) $(OPCODES) +nm_new_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +ar_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@ +strings_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +strip_new_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +ranlib_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@ +cxxfilt_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +objcopy_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +nlmconv_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +srconv_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +sysdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +coffdump_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +dlltool_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@ +windres_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) @LEXLIB@ +addr2line_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) $(BFDLIB) +readelf_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) +dllwrap_DEPENDENCIES = $(LIBINTL_DEP) $(LIBIBERTY) LDADD = $(BFDLIB) $(LIBIBERTY) $(LIBINTL) -- Alan Modra IBM OzLabs - Linux Technology Centre