From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5627 invoked by alias); 7 Nov 2009 05:31:34 -0000 Received: (qmail 5617 invoked by uid 22791); 7 Nov 2009 05:31:34 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 Nov 2009 05:31:30 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA75VSmu012332 for ; Sat, 7 Nov 2009 00:31:28 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA75VRoE005049 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Sat, 7 Nov 2009 00:31:28 -0500 Date: Sat, 07 Nov 2009 05:31:00 -0000 From: Kevin Buettner To: rda@sources.redhat.com Subject: [commit] Minor lib/gdbserv-output optimization Message-ID: <20091106223127.6b2e4153@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact rda-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: rda-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00000.txt.bz2 While comparing Red Hat's internal RDA sources to the public ones, I came across this old change by Michael Snyder. Committed. Kevin 2009-11-06 Kevin Buettner From Michael Snyder (circa 2004): * lib/gdbserv-output.c (gdbserv_output_string_as_bytes): Pull strlen out of loop for optimization. (gdbserv_output_string): Ditto. Index: lib/gdbserv-output.c =================================================================== RCS file: /cvs/src/src/rda/lib/gdbserv-output.c,v retrieving revision 1.2 diff -u -p -r1.2 gdbserv-output.c --- lib/gdbserv-output.c 24 Sep 2004 21:18:59 -0000 1.2 +++ lib/gdbserv-output.c 7 Nov 2009 05:19:35 -0000 @@ -57,7 +57,9 @@ void gdbserv_output_string_as_bytes (struct gdbserv *gdbserv, const char *packet) { int i; - for (i = 0; i < strlen (packet); i++) + int len = strlen (packet); + + for (i = 0; i < len; i++) { gdbserv_output_byte (gdbserv, packet[i]); } @@ -67,7 +69,9 @@ void gdbserv_output_string (struct gdbserv *gdbserv, const char *packet) { int i; - for (i = 0; i < strlen (packet); i++) + int len = strlen (packet); + + for (i = 0; i < len; i++) gdbserv_output_char (gdbserv, packet[i]); }