From: Michael Snyder <msnyder@redhat.com>
To: Michael Elizabeth Chastain <mec.gnu@mindspring.com>
Cc: binutils@sources.redhat.com, cagney@gnu.org,
gdb-patches@sources.redhat.com, rda@sources.redhat.com
Subject: Re: [RFA] rda/samples: improve memory allocation
Date: Mon, 12 Jul 2004 23:50:00 -0000 [thread overview]
Message-ID: <40F323D0.8020307@redhat.com> (raw)
In-Reply-To: <20040710032623.15A4D4B104@berman.michael-chastain.com>
Michael Elizabeth Chastain wrote:
> Michael Snyder writes:
>
> + #define ALLOC_UNIT 0x1000;
>
> Oops, extra semicolon!
>
> + #define alloc_roundup(LEN) ((LEN / ALLOC_UNIT) + ALLOC_UNIT)
>
> This looks like it's missing a multiplication again by ALLOC_UNIT.
> Say, if LEN is 0x3000, then alloc_roundup(LEN) comes out to 0x1003
> which seems weird.
>
> Perhaps:
>
> #define alloc_roundup(LEN) ((((LEN)+ALLOC_UNIT-1) / ALLOC_UNIT) * ALLOC_UNIT)
>
> Or I dunno exactly what you want, but that definition doesn't look
> right. Looks like a missing call to alloc_coffee somewhere ...
Mmm, for some reason, I've always been roundup-challenged.
Withdrawn and re-submitted, with your suggestions. Thanks.
[msnyder@dhcp-172-16-25-160 samples]$ make coffee
make: *** No rule to make target `coffee'. Stop.
next prev parent reply other threads:[~2004-07-12 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-10 3:26 Michael Elizabeth Chastain
2004-07-12 23:50 ` Michael Snyder [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-07-09 21:39 Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F323D0.8020307@redhat.com \
--to=msnyder@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
--cc=rda@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).