public inbox for rda@sourceware.org
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: rda@sources.redhat.com
Subject: RFA: use enum type for struct symbol_cache definition
Date: Tue, 19 Oct 2004 19:47:00 -0000	[thread overview]
Message-ID: <vt26556lcfc.fsf@zenia.home> (raw)


2004-10-19  Jim Blandy  <jimb@redhat.com>

	* thread-db.c (enum symbol_cache_defined): Move this definition
	above that of (struct symbol_cache), and give it a name.
	(struct symbol_cache): Use that enum as the type of 'defined_p', so
	the debugger will print symbol cache entries more helpfully.

*** thread-db.c.~1.5.~	2004-09-22 14:29:41.000000000 -0500
--- thread-db.c	2004-10-19 14:42:28.000000000 -0500
***************
*** 53,68 ****
   * in an "undefined" state, and then defined later.
   */
  
  struct symbol_cache {
    char *name;
    paddr_t value;
!   int  defined_p;
    struct symbol_cache *next;
  } *symbol_list;
  
- /* The "defined_p" field may have one of the following three values. */
- enum { UNDEFINED, REQUESTED, DEFINED };
- 
  /* Function: add_symbol_to_list
     Add a symbol to the symbol cache.  First checks to see if 
     an entry is already in there, and re-uses it if so.  This way
--- 53,68 ----
   * in an "undefined" state, and then defined later.
   */
  
+ /* The "defined_p" field may have one of the following three values. */
+ enum symbol_cache_defined { UNDEFINED, REQUESTED, DEFINED };
+ 
  struct symbol_cache {
    char *name;
    paddr_t value;
!   enum symbol_cache_defined  defined_p;
    struct symbol_cache *next;
  } *symbol_list;
  
  /* Function: add_symbol_to_list
     Add a symbol to the symbol cache.  First checks to see if 
     an entry is already in there, and re-uses it if so.  This way

             reply	other threads:[~2004-10-19 19:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-19 19:47 Jim Blandy [this message]
2004-10-19 20:05 ` Kevin Buettner
2004-10-19 21:20   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt26556lcfc.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=rda@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).