From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30324 invoked by alias); 19 Oct 2004 19:39:07 -0000 Mailing-List: contact rda-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rda-owner@sources.redhat.com Received: (qmail 30314 invoked from network); 19 Oct 2004 19:39:07 -0000 To: rda@sources.redhat.com Subject: RFA: avoid deprecated sys_nerr variable From: Jim Blandy Date: Tue, 19 Oct 2004 19:39:00 -0000 Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-q4/txt/msg00012.txt.bz2 2004-10-12 Jim Blandy * ptrace-target.c (ptrace_create_child): Don't use sys_nerr to check that errno is in a valid range. The use sys_nerr is deprecated on GNU/Linux, and according to the ISO C standard and POSIX, strerror always returns a valid string, even for invalid errno codes. Index: rda/unix/ptrace-target.c =================================================================== RCS file: /cvs/src/src/rda/unix/ptrace-target.c,v retrieving revision 1.6 diff -c -r1.6 ptrace-target.c *** rda/unix/ptrace-target.c 19 Mar 2004 18:26:08 -0000 1.6 --- rda/unix/ptrace-target.c 12 Oct 2004 23:17:56 -0000 *************** *** 122,129 **** sleep (-1); /* FIXME ??? */ fprintf (stderr, "Cannot exec %s: %s.\n", process->executable, ! errno > 0 && errno < sys_nerr ? ! strerror (errno) : "unknown error"); fail: fflush (stderr); _exit (0177); --- 122,128 ---- sleep (-1); /* FIXME ??? */ fprintf (stderr, "Cannot exec %s: %s.\n", process->executable, ! strerror (errno)); fail: fflush (stderr); _exit (0177);