From: Jim Blandy <jimb@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: rda@sources.redhat.com
Subject: Re: [PATCH] thread-db.c: Avoid segfault by making sure that ``reg'' is initialized
Date: Tue, 14 Dec 2004 18:16:00 -0000 [thread overview]
Message-ID: <vt2oegwrbln.fsf@zenia.home> (raw)
In-Reply-To: <20041213142538.7dc600c7@ironwood.lan>
Kevin Buettner <kevinb@redhat.com> writes:
> On Thu, 18 Nov 2004 18:02:40 -0700
> Kevin Buettner <kevinb@redhat.com> wrote:
>
> > [Hopefully, this'll end up in the right list this time...]
> >
> > I've just committed the patch below. As indicated by the subject line, this
> > patch prevents a segfault when thread_db_set_thread_reg() returns an
> > uninitialized ``reg''. (This was happening on Fedora Core 2 due to lack of
> > xregset support.)
> >
> > * thread-db.c (thread_db_set_thread_reg): Don't allow a successful
> > return without first initializing ``reg''.
>
> This patch was wrong - I didn't look closely enough at the result of
> applying a patch from a branch. Hopefully, this time I've applied the
> correct fix...
>
> * thread-db.c (thread_db_get_thread_reg): Don't allow a successful
> return without first initializing ``reg''.
> (thread_db_set_thread_reg): Remove code intended to for
> thread_db_get_thread_reg().
That's it --- no soup for you!
prev parent reply other threads:[~2004-12-14 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-19 1:02 Kevin Buettner
2004-12-13 21:25 ` Kevin Buettner
2004-12-14 18:16 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vt2oegwrbln.fsf@zenia.home \
--to=jimb@redhat.com \
--cc=kevinb@redhat.com \
--cc=rda@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).