public inbox for rda@sourceware.org
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@redhat.com>
To: rda@sources.redhat.com
Subject: RFA: emit semicolon in 'p' packet reply only if more regs to come
Date: Thu, 07 Oct 2004 22:43:00 -0000	[thread overview]
Message-ID: <vt2oejep2t6.fsf@zenia.home> (raw)


2004-10-07  Jim Blandy  <jimb@redhat.com>

	* lib/gdbserv-state.c (do_get_registers_p_packet): Don't produce a
	';' trailing the register value unless there are more register
	values to come.  This makes the multi-register packet
	upward-compatible with the single-register request / reply
	expected by GDB.

Index: rda/lib/gdbserv-state.c
===================================================================
RCS file: /cvs/src/src/rda/lib/gdbserv-state.c,v
retrieving revision 1.3
diff -c -p -r1.3 gdbserv-state.c
*** rda/lib/gdbserv-state.c	9 Jul 2004 20:00:25 -0000	1.3
--- rda/lib/gdbserv-state.c	7 Oct 2004 22:41:38 -0000
*************** do_get_registers_p_packet (struct gdbser
*** 605,617 ****
  	      result = "E02";
  	      break;
  	    }
- 	  gdbserv_output_string (gdbserv, ";");
  	  if (gdbserv_input_string_match (gdbserv, ";") < 0)
  	    {
  	      if (gdbserv_input_size (gdbserv) > 0)
  		result = "E03";
  	      break;
  	    }
  	}
        if (result != NULL)
  	{
--- 605,617 ----
  	      result = "E02";
  	      break;
  	    }
  	  if (gdbserv_input_string_match (gdbserv, ";") < 0)
  	    {
  	      if (gdbserv_input_size (gdbserv) > 0)
  		result = "E03";
  	      break;
  	    }
+           gdbserv_output_string (gdbserv, ";");
  	}
        if (result != NULL)
  	{

             reply	other threads:[~2004-10-07 22:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-07 22:43 Jim Blandy [this message]
2004-10-07 23:20 ` Kevin Buettner
2004-10-08  5:05   ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vt2oejep2t6.fsf@zenia.home \
    --to=jimb@redhat.com \
    --cc=rda@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).