From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rda-return-93-listarch-rda=sources.redhat.com@sources.redhat.com>
Received: (qmail 24546 invoked by alias); 7 Oct 2004 22:43:51 -0000
Mailing-List: contact rda-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:rda-subscribe@sources.redhat.com>
List-Post: <mailto:rda@sources.redhat.com>
List-Help: <mailto:rda-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: rda-owner@sources.redhat.com
Received: (qmail 24517 invoked from network); 7 Oct 2004 22:43:46 -0000
To: rda@sources.redhat.com
Subject: RFA: emit semicolon in 'p' packet reply only if more regs to come
From: Jim Blandy <jimb@redhat.com>
Date: Thu, 07 Oct 2004 22:43:00 -0000
Message-ID: <vt2oejep2t6.fsf@zenia.home>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-q4/txt/msg00009.txt.bz2


2004-10-07  Jim Blandy  <jimb@redhat.com>

	* lib/gdbserv-state.c (do_get_registers_p_packet): Don't produce a
	';' trailing the register value unless there are more register
	values to come.  This makes the multi-register packet
	upward-compatible with the single-register request / reply
	expected by GDB.

Index: rda/lib/gdbserv-state.c
===================================================================
RCS file: /cvs/src/src/rda/lib/gdbserv-state.c,v
retrieving revision 1.3
diff -c -p -r1.3 gdbserv-state.c
*** rda/lib/gdbserv-state.c	9 Jul 2004 20:00:25 -0000	1.3
--- rda/lib/gdbserv-state.c	7 Oct 2004 22:41:38 -0000
*************** do_get_registers_p_packet (struct gdbser
*** 605,617 ****
  	      result = "E02";
  	      break;
  	    }
- 	  gdbserv_output_string (gdbserv, ";");
  	  if (gdbserv_input_string_match (gdbserv, ";") < 0)
  	    {
  	      if (gdbserv_input_size (gdbserv) > 0)
  		result = "E03";
  	      break;
  	    }
  	}
        if (result != NULL)
  	{
--- 605,617 ----
  	      result = "E02";
  	      break;
  	    }
  	  if (gdbserv_input_string_match (gdbserv, ";") < 0)
  	    {
  	      if (gdbserv_input_size (gdbserv) > 0)
  		result = "E03";
  	      break;
  	    }
+           gdbserv_output_string (gdbserv, ";");
  	}
        if (result != NULL)
  	{