public inbox for rda@sourceware.org
 help / color / mirror / Atom feed
* RFA: emit semicolon in 'p' packet reply only if more regs to come
@ 2004-10-07 22:43 Jim Blandy
  2004-10-07 23:20 ` Kevin Buettner
  0 siblings, 1 reply; 3+ messages in thread
From: Jim Blandy @ 2004-10-07 22:43 UTC (permalink / raw)
  To: rda


2004-10-07  Jim Blandy  <jimb@redhat.com>

	* lib/gdbserv-state.c (do_get_registers_p_packet): Don't produce a
	';' trailing the register value unless there are more register
	values to come.  This makes the multi-register packet
	upward-compatible with the single-register request / reply
	expected by GDB.

Index: rda/lib/gdbserv-state.c
===================================================================
RCS file: /cvs/src/src/rda/lib/gdbserv-state.c,v
retrieving revision 1.3
diff -c -p -r1.3 gdbserv-state.c
*** rda/lib/gdbserv-state.c	9 Jul 2004 20:00:25 -0000	1.3
--- rda/lib/gdbserv-state.c	7 Oct 2004 22:41:38 -0000
*************** do_get_registers_p_packet (struct gdbser
*** 605,617 ****
  	      result = "E02";
  	      break;
  	    }
- 	  gdbserv_output_string (gdbserv, ";");
  	  if (gdbserv_input_string_match (gdbserv, ";") < 0)
  	    {
  	      if (gdbserv_input_size (gdbserv) > 0)
  		result = "E03";
  	      break;
  	    }
  	}
        if (result != NULL)
  	{
--- 605,617 ----
  	      result = "E02";
  	      break;
  	    }
  	  if (gdbserv_input_string_match (gdbserv, ";") < 0)
  	    {
  	      if (gdbserv_input_size (gdbserv) > 0)
  		result = "E03";
  	      break;
  	    }
+           gdbserv_output_string (gdbserv, ";");
  	}
        if (result != NULL)
  	{

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-10-08  5:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-07 22:43 RFA: emit semicolon in 'p' packet reply only if more regs to come Jim Blandy
2004-10-07 23:20 ` Kevin Buettner
2004-10-08  5:05   ` Jim Blandy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).