* RFA: avoid deprecated sys_nerr variable
@ 2004-10-19 19:39 Jim Blandy
2004-10-19 20:03 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: Jim Blandy @ 2004-10-19 19:39 UTC (permalink / raw)
To: rda
2004-10-12 Jim Blandy <jimb@redhat.com>
* ptrace-target.c (ptrace_create_child): Don't use sys_nerr to
check that errno is in a valid range. The use sys_nerr is
deprecated on GNU/Linux, and according to the ISO C standard and
POSIX, strerror always returns a valid string, even for invalid
errno codes.
Index: rda/unix/ptrace-target.c
===================================================================
RCS file: /cvs/src/src/rda/unix/ptrace-target.c,v
retrieving revision 1.6
diff -c -r1.6 ptrace-target.c
*** rda/unix/ptrace-target.c 19 Mar 2004 18:26:08 -0000 1.6
--- rda/unix/ptrace-target.c 12 Oct 2004 23:17:56 -0000
***************
*** 122,129 ****
sleep (-1); /* FIXME ??? */
fprintf (stderr, "Cannot exec %s: %s.\n", process->executable,
! errno > 0 && errno < sys_nerr ?
! strerror (errno) : "unknown error");
fail:
fflush (stderr);
_exit (0177);
--- 122,128 ----
sleep (-1); /* FIXME ??? */
fprintf (stderr, "Cannot exec %s: %s.\n", process->executable,
! strerror (errno));
fail:
fflush (stderr);
_exit (0177);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RFA: avoid deprecated sys_nerr variable
2004-10-19 19:39 RFA: avoid deprecated sys_nerr variable Jim Blandy
@ 2004-10-19 20:03 ` Kevin Buettner
2004-10-19 21:17 ` Jim Blandy
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2004-10-19 20:03 UTC (permalink / raw)
To: Jim Blandy; +Cc: rda
On 19 Oct 2004 14:37:13 -0500
Jim Blandy <jimb@redhat.com> wrote:
> 2004-10-12 Jim Blandy <jimb@redhat.com>
>
> * ptrace-target.c (ptrace_create_child): Don't use sys_nerr to
> check that errno is in a valid range. The use sys_nerr is
> deprecated on GNU/Linux, and according to the ISO C standard and
> POSIX, strerror always returns a valid string, even for invalid
> errno codes.
Okay.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: RFA: avoid deprecated sys_nerr variable
2004-10-19 20:03 ` Kevin Buettner
@ 2004-10-19 21:17 ` Jim Blandy
0 siblings, 0 replies; 3+ messages in thread
From: Jim Blandy @ 2004-10-19 21:17 UTC (permalink / raw)
To: Kevin Buettner; +Cc: rda
Kevin Buettner <kevinb@redhat.com> writes:
> On 19 Oct 2004 14:37:13 -0500
> Jim Blandy <jimb@redhat.com> wrote:
>
> > 2004-10-12 Jim Blandy <jimb@redhat.com>
> >
> > * ptrace-target.c (ptrace_create_child): Don't use sys_nerr to
> > check that errno is in a valid range. The use sys_nerr is
> > deprecated on GNU/Linux, and according to the ISO C standard and
> > POSIX, strerror always returns a valid string, even for invalid
> > errno codes.
>
> Okay.
Committed, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-19 21:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-19 19:39 RFA: avoid deprecated sys_nerr variable Jim Blandy
2004-10-19 20:03 ` Kevin Buettner
2004-10-19 21:17 ` Jim Blandy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).