From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15596 invoked by alias); 23 Oct 2002 18:20:15 -0000 Mailing-List: contact rhdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rhdb-owner@sources.redhat.com Received: (qmail 15555 invoked from network); 23 Oct 2002 18:20:12 -0000 Received: from unknown (HELO smtp012.mail.yahoo.com) (216.136.173.32) by sources.redhat.com with SMTP; 23 Oct 2002 18:20:12 -0000 Received: from pppoe1227.gh.centurytel.net (HELO thor.local) (brett?schwarz@64.91.48.249 with plain) by smtp.mail.vip.sc5.yahoo.com with SMTP; 23 Oct 2002 18:20:12 -0000 Subject: rhdb-admin From: Brett Schwarz To: rhdb@sources.redhat.com Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Wed, 23 Oct 2002 11:20:00 -0000 Message-Id: <1035397212.6808.92.camel@thor> Mime-Version: 1.0 X-SW-Source: 2002-q4/txt/msg00003.txt.bz2 No patches, but some recommendations: 1) Whenever you use 'expr', you should enclose the args in curly brackets: expr 1 + 2 should be: expr {1 +2} Same goes for 'if' statements, although I didn't explicitly see any... This prevents double substitution (i.e. double processing). Not a big thing, but if there are alot of them, it may add up in the performance. This should work in most of the cases (there are some outliners). 2) To load Itcl, Itk, and Iwidgets, you only need to do package require Iwidgets ... it loads Itk, and Itcl as well... 3) You also gain some by packing widgets together that have the same pack options. 4) In some of the classes, the Itcl commands are not fully qualified, and rhdb-admin doesn't even startup. I just added namespace import ::itcl::* to make it work, but maybe a better idea is to fully qualify the Itcl commands, unless you know for sure there won't be any name clashing. (I think the one I remember was configbody in NewDisjointListBoxWidget class) I haven't gone through thoroughly yet, but looks good... HTH, --brett p.s. more performance tips here: http://mini.net/tcl/348 -- Brett Schwarz brett_schwarz AT yahoo.com