From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25880 invoked by alias); 25 Jun 2003 02:43:14 -0000 Mailing-List: contact rhdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rhdb-owner@sources.redhat.com Received: (qmail 22571 invoked from network); 25 Jun 2003 01:23:40 -0000 Received: from unknown (HELO pd3mo2so.prod.shaw.ca) (24.71.223.10) by sources.redhat.com with SMTP; 25 Jun 2003 01:23:40 -0000 Received: from pd5mr4so.prod.shaw.ca (pd5mr4so-qfe3.prod.shaw.ca [10.0.141.168]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.16 (built May 14 2003)) with ESMTP id <0HH0001M8JVFIA@l-daemon> for rhdb@sources.redhat.com; Tue, 24 Jun 2003 19:23:39 -0600 (MDT) Received: from pn2ml2so.prod.shaw.ca (pn2ml2so-qfe0.prod.shaw.ca [10.0.121.146]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.16 (built May 14 2003)) with ESMTP id <0HH0003FCJVFZM@l-daemon> for rhdb@sources.redhat.com; Tue, 24 Jun 2003 19:23:39 -0600 (MDT) Received: from fanshawe.localdomain (h24-86-72-237.ed.shawcable.net [24.86.72.237]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.16 (built May 14 2003)) with ESMTP id <0HH000D4YJVFY1@l-daemon> for rhdb@sources.redhat.com; Tue, 24 Jun 2003 19:23:39 -0600 (MDT) Received: by fanshawe.localdomain (Postfix, from userid 500) id 3629C17DD; Tue, 24 Jun 2003 19:23:39 -0600 (MDT) Date: Wed, 25 Jun 2003 02:43:00 -0000 From: Liam Stewart Subject: [patch] planner option dialog consistency To: rhdb@sources.redhat.com Message-id: <20030625012339.GC23872@ualberta.ca> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_tWxU4ux/+tvbinMm87Vi7g)" User-Agent: Mutt/1.4.1i X-SW-Source: 2003-q2/txt/msg00054.txt.bz2 --Boundary_(ID_tWxU4ux/+tvbinMm87Vi7g) Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT Content-disposition: inline Content-length: 354 The attached patch makes the planner option dialog work like the other dialogs. Size and location are always reset whenever the window is opened. The menu seperators between the planner opts, db config, and preferences menu items are removed so that all three configuration box actions are grouped together. Liam -- Liam Stewart :: liam@ualberta.ca --Boundary_(ID_tWxU4ux/+tvbinMm87Vi7g) Content-type: text/plain; charset=us-ascii; NAME=planner.diff Content-transfer-encoding: 7BIT Content-disposition: attachment; filename=planner.diff Content-length: 2690 Index: rhdb-explain/src/com/redhat/rhdb/vise/PlannerOptionsDialog.java =================================================================== RCS file: /cvs/rhdb/src/rhdb-explain/src/com/redhat/rhdb/vise/PlannerOptionsDialog.java,v retrieving revision 1.1.1.1 diff -c -r1.1.1.1 PlannerOptionsDialog.java *** rhdb-explain/src/com/redhat/rhdb/vise/PlannerOptionsDialog.java 27 Feb 2003 16:29:23 -0000 1.1.1.1 --- rhdb-explain/src/com/redhat/rhdb/vise/PlannerOptionsDialog.java 25 Jun 2003 00:20:09 -0000 *************** *** 27,32 **** --- 27,33 ---- public class PlannerOptionsDialog extends javax.swing.JDialog { private ActionFactory afactory; private GenericAction okAction, cancelAction; + private java.awt.Frame owner; private JPanel poperations; private JCheckBox seqscan; private JCheckBox indexscan; *************** *** 77,82 **** --- 78,84 ---- public PlannerOptionsDialog(PlannerOptions defs, java.awt.Frame parent) { super(parent, true); this.defopts = defs; + this.owner = parent; // Actions afactory = new ActionFactory(); *************** *** 146,152 **** getContentPane().setLayout(new javax.swing.BoxLayout(getContentPane(), javax.swing.BoxLayout.Y_AXIS)); setTitle(ExplainResources.getString(ExplainResources.PLANNEROPTIONS_TITLE)); - setLocationRelativeTo(getOwner()); addWindowListener(new java.awt.event.WindowAdapter() { public void windowClosing(java.awt.event.WindowEvent evt) { closeDialog(evt); --- 148,153 ---- *************** *** 432,437 **** --- 433,448 ---- //dispose(); } + /** + * Show the dialog. + */ + public void show() + { + setSize(getPreferredSize()); + setLocationRelativeTo(owner); + super.show(); + } + /** * Set the planner options object being edited to the new values * according to the user input. If the value is the default, Index: rhdb-explain/src/com/redhat/rhdb/vise/Vise.java =================================================================== RCS file: /cvs/rhdb/src/rhdb-explain/src/com/redhat/rhdb/vise/Vise.java,v retrieving revision 1.1.1.3 diff -c -r1.1.1.3 Vise.java *** rhdb-explain/src/com/redhat/rhdb/vise/Vise.java 27 Feb 2003 16:29:23 -0000 1.1.1.3 --- rhdb-explain/src/com/redhat/rhdb/vise/Vise.java 25 Jun 2003 00:20:12 -0000 *************** *** 1900,1912 **** menu.addSeparator(); menu.add(poptsAction.getMenuItem()); - - menu.addSeparator(); - menu.add(dbasesAction.getMenuItem()); - - menu.addSeparator(); - menu.add(prefsAction.getMenuItem()); // Statement menu --- 1900,1906 ---- --Boundary_(ID_tWxU4ux/+tvbinMm87Vi7g)--