From: Dhek Bhun Kho <bhun@chello.nl>
To: Rhug <rhug-rhats@sources.redhat.com>
Subject: rhino
Date: Sun, 05 Jan 2003 00:01:00 -0000 [thread overview]
Message-ID: <1041724873.22875.104.camel@tasslehof.bhun.net> (raw)
In-Reply-To: <20021218100705.GA1163@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
I was running a toplevel make using GCJ 3.2.1:
d `org.mozilla.javascript.LineBuffer.skipFormatChar()':
../../../rhug/rhino/upstream/src/org/mozilla/javascript/LineBuffer.java:455: Incompatible type for `&&'. Can't convert `int' to boolean.
private static final boolean checkSelf = Context.check && true;
^
../../../rhug/rhino/upstream/src/org/mozilla/javascript/LineBuffer.java:455: Incompatible type for `&&'. Can't convert `int' to boolean.
private static final boolean checkSelf = Context.check && true;
^
2 errors
Attached a diff to fix it, the Context.check is defined as a final
static boolean = true, so I hacked in (Context.check==true) which is
correct to do as Context.check should be true at all times, it is
unlikely that they will change this as they happily note that it is a
Design by contract requirement.
[-- Attachment #2: LineBuffer.diff --]
[-- Type: text/plain, Size: 460 bytes --]
--- /home/cvs/LineBuffer.java 2003-01-05 00:58:47.000000000 +0100
+++ ../../rhug/rhino/upstream/src/org/mozilla/javascript/LineBuffer.java 2003-01-05 00:56:17.000000000 +0100
@@ -452,5 +452,5 @@
private boolean hadCFSinceStringStart = false;
// Rudimentary support for Design-by-Contract
- private static final boolean checkSelf = Context.check && true;
+ private static final boolean checkSelf = (Context.check==true) && true;
}
prev parent reply other threads:[~2003-01-05 0:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-11 15:57 BCEL question Tom Tromey
2002-12-11 20:31 ` Anthony Green
2002-12-16 10:44 ` Tom Tromey
2002-12-18 2:07 ` Gary Benson
2002-12-30 16:39 ` Dhek Bhun Kho
2003-01-05 0:01 ` Dhek Bhun Kho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1041724873.22875.104.camel@tasslehof.bhun.net \
--to=bhun@chello.nl \
--cc=rhug-rhats@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).