From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21852 invoked by alias); 5 Jan 2003 00:01:27 -0000 Mailing-List: contact rhug-rhats-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rhug-rhats-owner@sources.redhat.com Received: (qmail 21845 invoked from network); 5 Jan 2003 00:01:26 -0000 Received: from unknown (HELO amsfep13-int.chello.nl) (213.46.243.24) by 209.249.29.67 with SMTP; 5 Jan 2003 00:01:26 -0000 Received: from node-c-6778.a2000.nl ([62.194.103.120]) by amsfep13-int.chello.nl (InterMail vM.5.01.05.17 201-253-122-126-117-20021021) with ESMTP id <20030105000113.SEVB13007.amsfep13-int.chello.nl@node-c-6778.a2000.nl> for ; Sun, 5 Jan 2003 01:01:13 +0100 Subject: rhino From: Dhek Bhun Kho To: Rhug In-Reply-To: <20021218100705.GA1163@redhat.com> References: <873cp4hzyk.fsf@fleche.redhat.com> <1039667582.2883.59.camel@escape> <87y96pvm53.fsf@fleche.redhat.com> <20021218100705.GA1163@redhat.com> Content-Type: multipart/mixed; boundary="=-kbPiaABJ+1aaeABoqyHU" Date: Sun, 05 Jan 2003 00:01:00 -0000 Message-Id: <1041724873.22875.104.camel@tasslehof.bhun.net> Mime-Version: 1.0 X-SW-Source: 2003-01/txt/msg00002.txt.bz2 --=-kbPiaABJ+1aaeABoqyHU Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 962 I was running a toplevel make using GCJ 3.2.1: d `org.mozilla.javascript.LineBuffer.skipFormatChar()': ../../../rhug/rhino/upstream/src/org/mozilla/javascript/LineBuffer.java:455: Incompatible type for `&&'. Can't convert `int' to boolean. private static final boolean checkSelf = Context.check && true; ^ ../../../rhug/rhino/upstream/src/org/mozilla/javascript/LineBuffer.java:455: Incompatible type for `&&'. Can't convert `int' to boolean. private static final boolean checkSelf = Context.check && true; ^ 2 errors Attached a diff to fix it, the Context.check is defined as a final static boolean = true, so I hacked in (Context.check==true) which is correct to do as Context.check should be true at all times, it is unlikely that they will change this as they happily note that it is a Design by contract requirement. --=-kbPiaABJ+1aaeABoqyHU Content-Disposition: attachment; filename=LineBuffer.diff Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; name=LineBuffer.diff; charset=ISO-8859-15 Content-length: 477 --- /home/cvs/LineBuffer.java 2003-01-05 00:58:47.000000000 +0100 +++ ../../rhug/rhino/upstream/src/org/mozilla/javascript/LineBuffer.java 20= 03-01-05 00:56:17.000000000 +0100 @@ -452,5 +452,5 @@ private boolean hadCFSinceStringStart =3D false;=0D =0D // Rudimentary support for Design-by-Contract=0D - private static final boolean checkSelf =3D Context.check && true;=0D + private static final boolean checkSelf =3D (Context.check=3D=3Dtrue) &= & true;=0D }=0D --=-kbPiaABJ+1aaeABoqyHU--