From: Alexandre Petit-Bianco <apbianco@cygnus.com>
To: "Anthony Green" <green@redhat.com>
Cc: rhug-rhats@sources.redhat.com
Subject: Re: xalan failures
Date: Fri, 31 Aug 2001 12:20:00 -0000 [thread overview]
Message-ID: <15247.58206.329154.341078@fencer.cygnus.com> (raw)
In-Reply-To: <005e01c130ca$c8fc75c0$5be6b4cd@cygnus.com>
Anthony Green writes:
> The second one is more serious....
>
> Wed Aug 29 00:26:38 2001 Anthony Green <green@redhat.com>
>
> * upstream/src/org/apache/xpath/DOM2Helper.java (isNodeAfter):
> Break the code just to avoid a compiler failure.
> * upstream/src/org/apache/xpath/NodeSet.java: Ditto.
>
> The compiler is just SEGV'ing.
This has been fixed with this patch:
http://gcc.gnu.org/ml/gcc-patches/2001-08/msg01495.html
I started the build yesterday evening and it took a while to
complete, but it did, with the appended library patch.
I'll start a build tonight and measure the time. We need to let people
know what to expect when building this thing.
./A
2001-08-31 Alexandre Petit-Bianco <apbianco@redhat.com>
Revert:
Wed Aug 29 00:26:38 2001 Anthony Green <green@redhat.com>
* upstream/src/org/apache/xpath/DOM2Helper.java (isNodeAfter):
Break the code just to avoid a compiler failure.
* upstream/src/org/apache/xpath/NodeSet.java: Ditto.
Index: DOM2Helper.java
===================================================================
RCS file: /cvs/rhug/rhug/xalan/upstream/src/org/apache/xpath/DOM2Helper.java,v
retrieving revision 1.2
diff -u -p -r1.2 DOM2Helper.java
--- DOM2Helper.java 2001/08/29 13:54:26 1.2
+++ DOM2Helper.java 2001/08/31 19:16:32
@@ -285,9 +285,7 @@ public class DOM2Helper extends DOMHelpe
// isNodeAfter will return true if node is after countedNode
// in document order. The base isNodeAfter is sloooow (relatively).
- // RHUG FIXE: break this in order to avoid a compiler failure.
- // return DOMHelper.isNodeAfter(node1, node2);
- return 0;
+ return DOMHelper.isNodeAfter(node1, node2);
}
}
Index: NodeSet.java
===================================================================
RCS file: /cvs/rhug/rhug/xalan/upstream/src/org/apache/xpath/NodeSet.java,v
retrieving revision 1.2
diff -u -p -r1.2 NodeSet.java
--- NodeSet.java 2001/08/29 13:54:26 1.2
+++ NodeSet.java 2001/08/31 19:16:33
@@ -628,9 +628,7 @@ public class NodeSet
break;
}
- // FIXME RHUG - break this code just to compile it
- // if (!DOM2Helper.isNodeAfter(node, child))
- if (false)
+ if (!DOM2Helper.isNodeAfter(node, child))
{
insertElementAt(node, i + 1);
@@ -699,9 +697,7 @@ public class NodeSet
break;
}
- // FIXME RHUG - break this code just to compile it
- // if (!DOM2Helper.isNodeAfter(node, child))
- if (false)
+ if (!DOM2Helper.isNodeAfter(node, child))
{
break;
}
parent reply other threads:[~2001-08-31 12:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <005e01c130ca$c8fc75c0$5be6b4cd@cygnus.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15247.58206.329154.341078@fencer.cygnus.com \
--to=apbianco@cygnus.com \
--cc=green@redhat.com \
--cc=rhug-rhats@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).