From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8332 invoked by alias); 13 Dec 2002 11:20:05 -0000 Mailing-List: contact rhug-rhats-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: rhug-rhats-owner@sources.redhat.com Received: (qmail 8293 invoked from network); 13 Dec 2002 11:19:57 -0000 Received: from unknown (HELO inauspicious.demon.co.uk) (193.237.142.182) by sources.redhat.com with SMTP; 13 Dec 2002 11:19:57 -0000 Received: from slippy.wire.rat ([192.168.1.1]) by inauspicious.demon.co.uk with esmtp (Exim 3.22 #1) id 18MnrH-0005Y5-00 for rhug-rhats@sources.redhat.com; Fri, 13 Dec 2002 11:19:55 +0000 Received: from slippy.wire.rat (localhost.localdomain [127.0.0.1]) by slippy.wire.rat (8.12.5/8.12.5) with ESMTP id gBDBJtaj018918 for ; Fri, 13 Dec 2002 11:19:55 GMT Received: (from gary@localhost) by slippy.wire.rat (8.12.5/8.12.5/Submit) id gBDBJsCf018916 for rhug-rhats@sources.redhat.com; Fri, 13 Dec 2002 11:19:54 GMT Date: Fri, 13 Dec 2002 03:20:00 -0000 From: Gary Benson To: rhug-rhats@sources.redhat.com Subject: Properties files Message-ID: <20021213111954.GA18208@redhat.com> Mail-Followup-To: rhug-rhats@sources.redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i X-PGP-Fingerprint: 6646 CF68 DEA8 07CA CA64 C18C A150 FC2D 85A8 F78B X-SW-Source: 2002-12/txt/msg00009.txt.bz2 Hi all, I just spent a couple of days chasing what I thought was a gcj bug but that turned out not to be. Some of the packages have .properties files as well as .java files, and these are dealt with in the Makefiles as follows: | FOOBAR_PROP_S = \ | file1.properties \ | file2.properties | | FOOBAR_PROP_O = $(FOOBAR_PROP_S:.properties=.o) | | %.o: %.properties | $(top_srcdir)/mkinstalldirs `dirname $@` | $(GCJ) --resource `echo $< | sed "s/.*\/src\/share\///g"` -o $@ -c $< | | lib_bar_foo_la_LIBADD = $(FOOBAR_PROP_O) Now, Tomcat 4 has one case where there exists File.java and File.properties, meaning that they both compile to the same .o file. This causes all sorts of 'multiple definition of File' and 'File changed size from 46 to 22 bytes in File.o' To avoid this in future I'd like to make the following changes to all packages that have .properties files. 1. Change FOOBAR_PROP_O = $(FOOBAR_PROP_S:.properties=.o) to FOOBAR_PROP_O = $(FOOBAR_PROP_S:.properties=_prop.o) 2. Change %.o: %.properties to %_prop.o: %.properties Any objections? Cheers, Gary [ gbenson@redhat.com ][ GnuPG 85A8F78B ][ http://inauspicious.org/ ]