public inbox for rhug-rhats@sourceware.org
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: rhug-rhats@sources.redhat.com
Subject: Re: [tromey@redhat.com (Tom Tromey)] FAIL: rhug build on Sat May 3 03:26:43 MDT 2003
Date: Wed, 21 May 2003 09:38:00 -0000	[thread overview]
Message-ID: <20030521093824.GE31476@redhat.com> (raw)
In-Reply-To: <1053502285.3465.9.camel@escape>

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

Anthony Green wrote:
> On Sat, 2003-05-03 at 15:08, Tom Tromey wrote:
> > rhug hasn't built for me in quite a while.
> > However, this is a different failure than usual.
> 
> I was able to build gnu.readline without incident.
> 
> My build falls down in xerces...
> 
> libtool: link:
> `upstream/src/org/apache/xerces/impl/msg/DOMMessages.properties.lo' is
> not a valid libtool object
> 
> ..which is an interesting error message since that file doesn't exist. 
> However, I do have a file like that which ends in ".loT". 
> 
> This probably has something to do with this change...
> 
> 2003-04-08 Gary Benson <gbenson@redhat.com>
>  
>         * Makefile.am: Build resources using libtool.
>         * Makefile.in: Rebuilt.
>  
> Gary - any ideas?

Hmmm, does this patch help?

[-- Attachment #2: xerces-2.2.1-relink.patch --]
[-- Type: text/plain, Size: 3114 bytes --]

Patch libtool so we don't relink at install time

--- ltmain.sh.orig	2003-03-28 11:37:25.000000000 -0500
+++ ltmain.sh	2003-03-28 16:32:23.000000000 -0500
@@ -832,6 +832,7 @@
     linker_flags=
     dllsearchpath=
     lib_search_path=`pwd`
+    inst_prefix_dir=
 
     avoid_version=no
     dlfiles=
@@ -964,6 +965,11 @@
 	  prev=
 	  continue
 	  ;;
+        inst_prefix)
+	  inst_prefix_dir="$arg"
+	  prev=
+	  continue
+	  ;;
 	release)
 	  release="-$arg"
 	  prev=
@@ -1172,6 +1178,11 @@
 	continue
 	;;
 
+      -inst-prefix-dir)
+	prev=inst_prefix
+	continue
+	;;
+
       # The native IRIX linker understands -LANG:*, -LIST:* and -LNO:*
       # so, if we see these flags be careful not to treat them like -L
       -L[A-Z][A-Z]*:*)
@@ -2245,7 +2256,16 @@
 	    if test "$hardcode_direct" = yes; then
 	      add="$libdir/$linklib"
 	    elif test "$hardcode_minus_L" = yes; then
-	      add_dir="-L$libdir"
+	      # Try looking first in the location we're being installed to.
+	      add_dir=
+	      if test -n "$inst_prefix_dir"; then
+		case "$libdir" in
+		[\\/]*)
+		  add_dir="-L$inst_prefix_dir$libdir"
+		  ;;
+		esac
+	      fi
+	      add_dir="$add_dir -L$libdir"
 	      add="-l$name"
 	    elif test "$hardcode_shlibpath_var" = yes; then
 	      case :$finalize_shlibpath: in
@@ -2255,7 +2275,16 @@
 	      add="-l$name"
 	    else
 	      # We cannot seem to hardcode it, guess we'll fake it.
-	      add_dir="-L$libdir"
+	      # Try looking first in the location we're being installed to.
+	      add_dir=
+	      if test -n "$inst_prefix_dir"; then
+		case "$libdir" in
+		[\\/]*)
+		  add_dir="-L$inst_prefix_dir$libdir"
+		  ;;
+		esac
+	      fi
+	      add_dir="$add_dir -L$libdir"
 	      add="-l$name"
 	    fi
 
@@ -4376,7 +4405,7 @@
 	fi
       done
       # Quote the link command for shipping.
-      relink_command="(cd `pwd`; $SHELL $0 --mode=relink $libtool_args)"
+      relink_command="(cd `pwd`; $SHELL $0 --mode=relink $libtool_args @inst_prefix_dir@)"
       relink_command=`$echo "X$relink_command" | $Xsed -e "$sed_quote_subst"`
 
       # Only create the output if not a dry run.
@@ -4677,6 +4706,24 @@
 	dir="$dir$objdir"
 
 	if test -n "$relink_command"; then
+	  # Determine the prefix the user has applied to our future dir.
+	  inst_prefix_dir=`$echo "$destdir" | sed "s%$libdir\$%%"`
+
+	  # Don't allow the user to place us outside of our expected
+	  # location b/c this prevents finding dependent libraries that
+	  # are installed to the same prefix.
+	  if test "$inst_prefix_dir" = "$destdir"; then
+	    $echo "$modename: error: cannot install \`$file' to a directory not ending in $libdir" 1>&2
+	    exit 1
+	  fi
+
+	  if test -n "$inst_prefix_dir"; then
+	    # Stick the inst_prefix_dir data into the link command.
+	    relink_command=`$echo "$relink_command" | sed "s%@inst_prefix_dir@%-inst-prefix-dir $inst_prefix_dir%"`
+	  else
+	    relink_command=`$echo "$relink_command" | sed "s%@inst_prefix_dir@%%"`
+	  fi
+
 	  $echo "$modename: warning: relinking \`$file'" 1>&2
 	  $show "$relink_command"
 	  if $run eval "$relink_command"; then :

  reply	other threads:[~2003-05-21  9:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-03 22:16 Tom Tromey
2003-05-06 13:24 ` Anthony Green
2003-05-21  7:31 ` Anthony Green
2003-05-21  9:38   ` Gary Benson [this message]
2003-05-21 15:46     ` Anthony Green
2003-05-21 16:44       ` Gary Benson
2003-05-21 19:15         ` Anthony Green
     [not found]           ` <20030522092501.GB15469@redhat.com>
     [not found]             ` <1053620895.3465.797.camel@escape>
2003-05-22 16:44               ` Gary Benson
2003-05-22 18:48                 ` Anthony Green
2003-05-23  8:42                   ` Gary Benson
2003-05-21 13:01   ` Stefan Seefeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030521093824.GE31476@redhat.com \
    --to=gbenson@redhat.com \
    --cc=rhug-rhats@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).